Update lint config

Author: jdalton

.oxlintrc.json

@@ -1,16 +1,10 @@
 {
   "settings": {},
   "rules": {
-    "@typescript-eslint/no-extraneous-class": "allow",
     "@typescript-eslint/no-this-alias": ["deny"],
-    "unicorn/consistent-function-scoping": "allow",
     "unicorn/no-empty-file": "allow",
     "unicorn/no-new-array": "allow",
-    "no-async-endpoint-handlers": "allow",
-    "no-await-in-loop": "allow",
     "no-control-regex": "allow",
-    "no-extend-native": "allow",
-    "no-new": "allow",
     "no-self-assign": "allow",
     "no-unused-vars": "allow"
   }

eslint.config.js

@@ -22,7 +22,7 @@ const sharedRules = {
   'no-control-regex': ['error'],
   'no-new': ['error'],
   'no-warning-comments': ['warn', { terms: ['fixme'] }],
-  'unicorn/consistent-function-scoping': 'off'
+  'unicorn/consistent-function-scoping': ['error']
 }
 
 module.exports = [

src/commands/login.ts

@@ -38,6 +38,10 @@ const flags: { [key: string]: any } = {
   }
 }
 
+function nonNullish<T>(value: T | null | undefined): value is T {
+  return value !== null && value !== undefined
+}
+
 export const login: CliSubcommand = {
   description,
   async run(argv, importMeta, { parentName }) {
@@ -110,9 +114,6 @@ export const login: CliSubcommand = {
       return
     }
 
-    const nonNullish = <T>(value: T | null | undefined): value is T =>
-      value != null
-
     const enforcedChoices: OrgChoices = Object.values(orgs.organizations)
       .filter(nonNullish)
       .filter(org => org.plan === 'enterprise')

src/utils/package-manager-detector.ts

@@ -90,19 +90,19 @@ type ReadLockFile = (
 ) => Promise<string | undefined>
 
 const readLockFileByAgent: Record<AgentPlusBun, ReadLockFile> = (() => {
-  const wrapReader =
-    (
-      reader: (
-        lockPath: string,
-        agentExecPath: string
-      ) => Promise<string | undefined>
-    ): ReadLockFile =>
-    async (lockPath: string, agentExecPath: string) => {
+  function wrapReader(
+    reader: (
+      lockPath: string,
+      agentExecPath: string
+    ) => Promise<string | undefined>
+  ): ReadLockFile {
+    return async (lockPath: string, agentExecPath: string) => {
       try {
         return await reader(lockPath, agentExecPath)
       } catch {}
       return undefined
     }
+  }
   return {
     bun: wrapReader(async (lockPath: string, agentExecPath: string) => {
       let lockBuffer: Buffer | undefined

test/path-resolve.test.ts

@@ -8,7 +8,6 @@ import nock from 'nock'
 import { getPackageFiles } from './dist/path-resolve'
 
 const testPath = __dirname
-const rootPath = path.resolve(__dirname, '..')
 const mockPath = path.join(testPath, 'mock')
 
 const globPatterns = {