Merge pull request #934 from Shopify/codex/env-promotable-rbs-constants

Mark RBS constants as promotable

Author: soutaro

rust/rubydex/src/indexing/rbs_indexer.rs

@@ -495,7 +495,10 @@ impl Visit for RBSIndexer<'_> {
             self.uri_id,
             offset,
             comments,
-            Self::flags(&constant_node.annotations()),
+            // RBS establishes that the constant exists, but its value type is intentionally not
+            // represented in the graph. Treat it like a dynamic Ruby assignment so resolution
+            // may promote it when a namespace or singleton receiver is required.
+            Self::flags(&constant_node.annotations()) | DefinitionFlags::PROMOTABLE,
             lexical_nesting_id,
         )));
 

rust/rubydex/src/resolution_tests.rs

@@ -4624,6 +4624,33 @@ mod promotability_tests {
         assert_declaration_does_not_exist!(context, "Foo::<Foo>#bar()");
     }
 
+    #[test]
+    fn rbs_constant_is_promotable_for_singleton_call() {
+        let mut context = graph_test();
+        context.index_rbs_uri("file:///env.rbs", "ENV: untyped");
+        context.index_uri("file:///env.rb", {
+            r#"
+            ENV.fetch("FEATURE")
+            "#
+        });
+        context.resolve();
+
+        assert_no_diagnostics!(&context);
+        assert_declaration_exists!(context, "ENV::<ENV>");
+
+        let fetch = context
+            .graph()
+            .method_references()
+            .values()
+            .find(|method| *method.str() == "fetch".into())
+            .expect("ENV.fetch should be indexed");
+        let receiver_name_id = fetch.receiver().expect("ENV.fetch should have a receiver");
+        let NameRef::Resolved(receiver) = context.graph().names().get(&receiver_name_id).unwrap() else {
+            panic!("ENV.fetch receiver should resolve");
+        };
+        assert_eq!(*receiver.declaration_id(), DeclarationId::from("ENV::<ENV>"));
+    }
+
     #[test]
     fn ivar_defined_inside_of_undefined_alias_namespace() {
         let mut context = graph_test();