updated review comments

Author: Venkatakrishnan774

src/sap_cloud_sdk/outputmanagement/clients/email_client.py

@@ -1,15 +1,24 @@
 """Email client for simplified email sending via SAP Ariba Output Service."""
 
-from typing import Optional, List, Dict, Any
+import logging
+from typing import Optional, List, Dict, Any, TYPE_CHECKING
+
 from ..models.output_request import OutputRequest
 from ..models.output_request_data import OutputRequestData
 from ..models.output_management_info import OutputManagementInfo
 from ..models.email_configuration import EmailConfiguration
 from ..models.output_response import OutputResponse, ErrorResponse
+from ..models.attachment_config import AttachmentConfig
+from ..models.pre_generated_attachment import PreGeneratedAttachment
 from ..config.destination_credential_config import DestinationCredentialConfig
 from ..constants import Channel
 from ..utils.request_validator import RequestValidator
 
+if TYPE_CHECKING:
+    from ..client_provider import OutputManagementServiceClientProviderBuilder
+
+logger = logging.getLogger(__name__)
+
 
 class EmailClient:
     """
@@ -67,9 +76,6 @@ def create_output_request(
         # Build attachment config if URLs are provided
         attachment_config = None
         if attachment_urls:
-            from ..models.attachment_config import AttachmentConfig
-            from ..models.pre_generated_attachment import PreGeneratedAttachment
-            
             # Convert URLs to PreGeneratedAttachment objects
             pre_gen_attachments = [
                 PreGeneratedAttachment(url=url, source="DMS")
@@ -217,10 +223,8 @@ def send_email(
             )
 
         try:
-            # Import here to avoid circular import at module initialization
+            # Import here to avoid circular import (client.py -> email_client.py -> client_provider.py -> client.py)
             from ..client_provider import OutputManagementServiceClientProviderBuilder
-            import logging
-            logger = logging.getLogger(__name__)
 
             # Resolve instance name for logging
             inst = instance or "default"

src/sap_cloud_sdk/outputmanagement/clients/output_requests_client_impl.py

@@ -1,12 +1,20 @@
 """Implementation of output requests client."""
 
+import base64
 import logging
 import os
+import tempfile
 import uuid
 from typing import Dict, Optional
 
 import requests
-from sap_cloud_sdk.destination import Destination
+from cryptography.hazmat.primitives.serialization import (
+    pkcs12,
+    Encoding,
+    PrivateFormat,
+    NoEncryption,
+)
+from sap_cloud_sdk.destination import Destination, create_certificate_client, AccessStrategy
 
 from .output_requests_client import OutputRequestsClient
 from ..constants import Constants
@@ -181,11 +189,6 @@ def _fetch_oauth_token_from_destination(self) -> Optional[str]:
 
             # Get certificate from Cloud SDK Destination Service
             try:
-                from sap_cloud_sdk.destination import create_certificate_client, AccessStrategy
-                import tempfile
-                import base64
-                from cryptography.hazmat.primitives.serialization import pkcs12, Encoding, PrivateFormat, NoEncryption
-                
                 # Resolve instance name: use provided value or default to "default" (following DMS pattern)
                 inst = self._destination_instance or "default"
                 logger.info(f"✓ Creating certificate client for instance '{inst}'")