updated roff

Author: Venkatakrishnan774

src/sap_cloud_sdk/outputmanagement/config.py

@@ -4,6 +4,8 @@
 from pydantic import BaseModel, Field, field_validator
 import logging
 
+from sap_cloud_sdk.destination import create_client, AccessStrategy
+
 logger = logging.getLogger(__name__)
 
 
@@ -69,15 +71,13 @@ class Config:
 
     def get_destination(self):
         """Retrieve the destination from SAP BTP Destination Service.
-        Uses relative import to access sap_cloud_sdk.destination module.
+        Uses top-level import to access sap_cloud_sdk.destination module.
         Returns:
             Destination object with URL, authentication, and properties
         Raises:
             ValueError: If destination is not found
             Exception: If destination retrieval fails
         """
-        from ...destination import create_client, AccessStrategy
-
         # Resolve instance name: use provided value or default to "default"
         inst = self.instance or "default"
         logger.info(

src/sap_cloud_sdk/outputmanagement/user-guide.md

@@ -440,7 +440,7 @@ from sap_cloud_sdk.outputmanagement import create_client
 
 try:
     client = create_client(destination_name="ARIBA_OUTPUT_SERVICE")
-    
+
     response = client.send_email(
         notification_template_key="NOTIFICATION",
         to=["user@example.com"],
@@ -481,7 +481,7 @@ for order in orders:
         to=[order.customer_email],
         business_document={"Order": order.to_dict()}
     )
-    
+
     if response.error:
         print(f"Failed to send email for order {order.id}: {response.error.message}")
     else:
@@ -505,7 +505,7 @@ def send_order_confirmation(order):
 
     # Create client and send
     client = create_client(destination_name="ARIBA_OUTPUT_SERVICE")
-    
+
     response = client.send_email(
         notification_template_key="ORDER_CONFIRMATION",
         to=[order.customer_email],
@@ -761,7 +761,7 @@ from sap_cloud_sdk.outputmanagement import create_client
 
 def send_order_confirmation(order):
     client = create_client(destination_name="ARIBA_OUTPUT_SERVICE")
-    
+
     response = client.send_email(
         notification_template_key="ORDER_CONFIRMATION",
         to=[order.customer_email],
@@ -794,7 +794,7 @@ from sap_cloud_sdk.outputmanagement import create_client
 
 def send_invoice_with_pdf(invoice, pdf_dms_url):
     client = create_client(destination_name="ARIBA_OUTPUT_SERVICE")
-    
+
     response = client.send_email(
         notification_template_key="INVOICE_WITH_PDF",
         to=[invoice.customer_email],
@@ -821,7 +821,7 @@ from sap_cloud_sdk.outputmanagement import create_client
 
 def send_bulk_notification(recipients, notification_data):
     client = create_client(destination_name="ARIBA_OUTPUT_SERVICE")
-    
+
     response = client.send_email(
         notification_template_key="BULK_NOTIFICATION",
         to=recipients,
@@ -894,16 +894,16 @@ from sap_cloud_sdk.outputmanagement import (
 
 try:
     client = create_client(destination_name="ARIBA_OUTPUT_SERVICE")
-    
+
     response = client.send_email(
         notification_template_key="NOTIFICATION",
         to=["user@example.com"],
         business_document={"Document": {"id": "123"}}
     )
-    
+
     if response.error:
         print(f"Error: {response.error.message}")
-        
+
 except ValidationException as e:
     print(f"Validation error: {e.message}")
 except AuthenticationException as e:
@@ -955,5 +955,5 @@ For issues or questions:
 
 ---
 
-**Version:** 3.0.0  
-**Last Updated:** 2026-06-23
+**Version:** 3.0.0
+**Last Updated:** 2026-06-23

tests/outputmanagement/unit/conftest.py

@@ -9,7 +9,7 @@
 @pytest.fixture
 def sample_email_config():
     """Provide a sample email configuration for testing."""
-    from sap_cloud_sdk.outputmanagement.models import EmailConfiguration
+    from sap_cloud_sdk.outputmanagement import EmailConfiguration
 
     return EmailConfiguration(
         emailNotificationTemplateKey="TEST_TEMPLATE",
@@ -21,7 +21,7 @@ def sample_email_config():
 @pytest.fixture
 def sample_attachment():
     """Provide a sample attachment for testing."""
-    from sap_cloud_sdk.outputmanagement.models import AttachmentConfig, FormConfiguration
+    from sap_cloud_sdk.outputmanagement import AttachmentConfig, FormConfiguration
 
     form_config = FormConfiguration(form_id="test-form")
     return AttachmentConfig(formConfiguration=form_config)
@@ -30,15 +30,15 @@ def sample_attachment():
 @pytest.fixture
 def sample_output_response():
     """Provide a sample output response for testing."""
-    from sap_cloud_sdk.outputmanagement.models import OutputResponse
+    from sap_cloud_sdk.outputmanagement import OutputResponse
 
     return OutputResponse(outputRequestId="test-req-123")
 
 
 @pytest.fixture
 def sample_pre_generated_attachment():
     """Provide a sample pre-generated attachment for testing."""
-    from sap_cloud_sdk.outputmanagement.models import PreGeneratedAttachment
+    from sap_cloud_sdk.outputmanagement import PreGeneratedAttachment
 
     return PreGeneratedAttachment(
         url="https://dms.example.com/attachments/test-file.pdf",
@@ -49,9 +49,7 @@ def sample_pre_generated_attachment():
 @pytest.fixture
 def sample_destination_config():
     """Provide a sample destination configuration for testing."""
-    from sap_cloud_sdk.outputmanagement.config.destination_credential_config import (
-        DestinationCredentialConfig,
-    )
+    from sap_cloud_sdk.outputmanagement import DestinationCredentialConfig
 
     return DestinationCredentialConfig(
         destination_name="test-output-management"

tests/outputmanagement/unit/test_basic.py

@@ -33,7 +33,7 @@ def test_constants_import(self):
         """Test that constants can be imported."""
         from sap_cloud_sdk.outputmanagement import FileFormat, Channel
         from sap_cloud_sdk.outputmanagement.constants import Constants
-        
+
         assert Constants.API_OUTPUT_CONTROL is not None
         assert FileFormat.PDF is not None
         assert Channel.INTERNAL_EMAIL is not None
@@ -88,4 +88,4 @@ def test_config_import(self):
     def test_utils_import(self):
         """Test that utils can be imported."""
         from sap_cloud_sdk.outputmanagement.utils import RequestValidator
-        assert RequestValidator is not None
+        assert RequestValidator is not None

tests/outputmanagement/unit/test_comprehensive.py

@@ -323,4 +323,4 @@ def test_email_with_dms_attachments_scenario(self):
         assert email.attachment is not None
         assert email.attachment.pre_generated_attachments is not None
         assert len(email.attachment.pre_generated_attachments) == 3
-        assert all(att.source == "DMS" for att in email.attachment.pre_generated_attachments)
+        assert all(att.source == "DMS" for att in email.attachment.pre_generated_attachments)

tests/outputmanagement/unit/test_email_client_mcp.py

@@ -384,4 +384,4 @@ async def test_send_email_with_mcp_no_optional_params(self, output_management_cl
         assert "cc" not in email_config or email_config.get("cc") is None
 
         # Attachment should not be present when not provided
-        assert "attachment" not in email_config or email_config.get("attachment") is None
+        assert "attachment" not in email_config or email_config.get("attachment") is None

tests/outputmanagement/unit/test_integration.py

@@ -203,4 +203,4 @@ def test_output_response_lifecycle(self):
         assert error.output_request_id is None
         assert error.error is not None
         assert error.error.message == "Failed to generate output"
-        assert error.error.code == "ERR_001"
+        assert error.error.code == "ERR_001"

tests/outputmanagement/unit/test_models.py

@@ -260,4 +260,4 @@ def test_pre_generated_attachment_equality(self):
         )
 
         assert att1 == att2
-        assert att1 != att3
+        assert att1 != att3