fix(dms): remove instance_name from BindingData and auto-create test repositories

Author: I559656

src/sap_cloud_sdk/dms/config.py

@@ -19,7 +19,6 @@ class BindingData:
         uaa: JSON string containing XSUAA authentication credentials
     """
 
-    instance_name: str
     uri: str
     uaa: str
 
@@ -78,20 +77,23 @@ def _validate_uaa(self) -> None:
                 f"UAA credentials missing required fields: {', '.join(sorted(missing_fields))}"
             )
 
-    def to_credentials(self) -> DMSCredentials:
+    def to_credentials(self, instance_name: str) -> DMSCredentials:
         """Convert the binding data to DMSCredentials.
 
         Parses the UAA JSON and constructs a DMSCredentials object with the necessary information
         for authenticating and connecting to the DMS service.
 
+        Args:
+            instance_name: The logical instance name for these credentials.
+
         Returns:
             DMSCredentials: The credentials extracted from the binding data
         """
         uaa_data: Dict[str, Any] = json.loads(self.uaa)
         token_url = uaa_data["url"].rstrip("/") + "/oauth/token"
 
         return DMSCredentials(
-            instance_name=self.instance_name,
+            instance_name=instance_name,
             uri=self.uri,
             client_id=uaa_data["clientid"],
             client_secret=uaa_data["clientsecret"],
@@ -114,7 +116,7 @@ def load_sdm_config_from_env_or_mount(instance: Optional[str] = None) -> DMSCred
     """
     inst = instance or "default"
     binding = BindingData(
-        uri="", uaa="", instance_name=""
+        uri="", uaa=""
     )  # Initialize with empty values; will be populated by resolver
 
     try:
@@ -129,7 +131,7 @@ def load_sdm_config_from_env_or_mount(instance: Optional[str] = None) -> DMSCred
         )
 
         binding.validate()
-        return binding.to_credentials()
+        return binding.to_credentials(inst)
 
     except Exception as e:
         # Rely on the central secret resolver to provide aggregated, generic guidance

tests/dms/integration/conftest.py

@@ -1,8 +1,14 @@
 from sap_cloud_sdk.dms import create_client
+from sap_cloud_sdk.dms.model import InternalRepoRequest
 import pytest
+import logging
 from pathlib import Path
 from dotenv import load_dotenv
 
+logger = logging.getLogger(__name__)
+
+_SDK_TEST_REPO_PREFIX = "sdk-integration-test-"
+
 
 @pytest.fixture(scope="session")
 def dms_client():
@@ -17,6 +23,44 @@ def dms_client():
         pytest.skip(f"DMS integration tests require credentials: {e}")
 
 
+@pytest.fixture(scope="session", autouse=True)
+def _setup_test_repositories(dms_client):
+    """Create test repositories for integration tests and clean up after.
+
+    Always onboards a standard and a version-enabled repository for the test
+    session, then deletes them on teardown.
+    """
+    created_repos = []
+
+    logger.info("Onboarding test repositories")
+    repo = dms_client.onboard_repository(
+        InternalRepoRequest(
+            displayName=f"{_SDK_TEST_REPO_PREFIX}standard",
+            description="Auto-created by SDK integration tests",
+        )
+    )
+    created_repos.append(repo.id)
+
+    repo = dms_client.onboard_repository(
+        InternalRepoRequest(
+            displayName=f"{_SDK_TEST_REPO_PREFIX}versioned",
+            description="Auto-created by SDK integration tests (versioning)",
+            isVersionEnabled=True,
+        )
+    )
+    created_repos.append(repo.id)
+
+    yield
+
+    # Cleanup: delete repositories we created
+    for repo_id in created_repos:
+        try:
+            dms_client.delete_repository(repo_id)
+            logger.info("Cleaned up test repository %s", repo_id)
+        except Exception as e:
+            logger.warning("Failed to clean up test repository %s: %s", repo_id, e)
+
+
 def _setup_cloud_mode():
     """Common setup for cloud mode integration tests."""
     env_file = Path(__file__).parents[3] / ".env_integration_tests"