Skip to content

Commit 14108e8

Browse files
committed
fix quality check
1 parent bbc69a7 commit 14108e8

4 files changed

Lines changed: 14 additions & 5 deletions

File tree

src/sap_cloud_sdk/agentgateway/_customer.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,8 @@ def load_customer_credentials_from_env() -> CustomerCredentials:
231231
)
232232

233233
logger.debug(
234-
"Loaded %d integration dependencies from environment", len(integration_dependencies)
234+
"Loaded %d integration dependencies from environment",
235+
len(integration_dependencies),
235236
)
236237

237238
return CustomerCredentials(
@@ -387,7 +388,8 @@ def _request_token_transparent(
387388
)
388389

389390
logger.debug(
390-
"Token acquired successfully (transparent mode, length: %d)", len(access_token)
391+
"Token acquired successfully (transparent mode, length: %d)",
392+
len(access_token),
391393
)
392394
return token_data
393395

@@ -417,6 +419,11 @@ def _request_token_mtls(
417419
Raises:
418420
AgentGatewaySDKError: If token request fails.
419421
"""
422+
if credentials.certificate is None or credentials.private_key is None:
423+
raise AgentGatewaySDKError(
424+
"mTLS token request requires certificate and private_key. "
425+
"Use _request_token_transparent() for TlsMode.TRANSPARENT."
426+
)
420427
ssl_context = _create_ssl_context(credentials.certificate, credentials.private_key)
421428

422429
data = {

src/sap_cloud_sdk/agentgateway/config.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,5 +68,9 @@ def from_env() -> "ClientConfig":
6868
otherwise STANDARD.
6969
"""
7070
raw = os.environ.get(_ENV_TLS_MODE, "").lower()
71-
tls_mode = TlsMode.TRANSPARENT if raw == TlsMode.TRANSPARENT.value else TlsMode.STANDARD
71+
tls_mode = (
72+
TlsMode.TRANSPARENT
73+
if raw == TlsMode.TRANSPARENT.value
74+
else TlsMode.STANDARD
75+
)
7276
return ClientConfig(tls_mode=tls_mode)

tests/agentgateway/unit/test_config.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,4 +76,3 @@ def test_from_env_unknown_value_falls_back_to_standard(self):
7676
with patch.dict(os.environ, {"AGW_TLS_MODE": "unknown"}):
7777
config = ClientConfig.from_env()
7878
assert config.tls_mode == TlsMode.STANDARD
79-

tests/agentgateway/unit/test_customer.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1017,4 +1017,3 @@ def test_returns_exchanged_token(self):
10171017
call_kwargs = mock_req.call_args
10181018
assert call_kwargs.kwargs["extra_data"]["assertion"] == "user-jwt"
10191019
assert call_kwargs.kwargs["grant_type"] == "urn:ietf:params:oauth:grant-type:jwt-bearer"
1020-

0 commit comments

Comments
 (0)