Added: Ability to optionally not dispose underlying Streams

Author: Sewer56

Source/Reloaded.Memory/Streams/Readers/BigEndianStreamReader.cs

@@ -1,5 +1,4 @@
-using System.Diagnostics.CodeAnalysis;
-using System.Runtime.CompilerServices;
+using System.Runtime.CompilerServices;
 
 namespace Reloaded.Memory.Streams.Readers
 {
@@ -13,6 +12,11 @@ public partial class BigEndianStreamReader : EndianStreamReader
         /// </summary>
         public BigEndianStreamReader(BufferedStreamReader streamReader) : base(streamReader) { }
 
+        /// <summary>
+        /// Constructs a <see cref="EndianStreamReader"/> given an existing stream reader.
+        /// </summary>
+        public BigEndianStreamReader(BufferedStreamReader streamReader, bool disposeUnderlyingStream = true) : base(streamReader, disposeUnderlyingStream) { }
+
         /// <inheritdoc />
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public override unsafe void Read<T>(out T value) => Reader.ReadBigEndianPrimitive(out value);

Source/Reloaded.Memory/Streams/Readers/EndianStreamReader.cs

@@ -15,6 +15,11 @@ public abstract partial class EndianStreamReader : IDisposable
         /// </summary>
         public BufferedStreamReader Reader { get; private set; }
 
+        /// <summary>
+        /// If this is set, the underlying stream will be disposed.
+        /// </summary>
+        public bool DisposeUnderlyingStream { get; private set; } = true;
+
         /* Properties (Written as methods to force inlining). */
 
         /// <summary>
@@ -50,6 +55,15 @@ public abstract partial class EndianStreamReader : IDisposable
         /// </summary>
         protected EndianStreamReader(BufferedStreamReader streamReader) => Reader = streamReader;
 
+        /// <summary>
+        /// Constructs a <see cref="EndianStreamReader"/> given an existing stream reader.
+        /// </summary>
+        protected EndianStreamReader(BufferedStreamReader streamReader, bool disposeUnderlyingStream)
+        {
+            Reader = streamReader;
+            DisposeUnderlyingStream = disposeUnderlyingStream;
+        }
+
         /// <summary/>
         ~EndianStreamReader()
         {
@@ -59,7 +73,9 @@ public abstract partial class EndianStreamReader : IDisposable
         /// <inheritdoc/>
         public void Dispose()
         {
-            Reader?.Dispose();
+            if (DisposeUnderlyingStream)
+                Reader?.Dispose();
+            
             GC.SuppressFinalize(this);
         }
 

Source/Reloaded.Memory/Streams/Readers/LittleEndianStreamReader.cs

@@ -1,5 +1,4 @@
-using System.Diagnostics.CodeAnalysis;
-using System.Runtime.CompilerServices;
+using System.Runtime.CompilerServices;
 
 namespace Reloaded.Memory.Streams.Readers
 {
@@ -13,6 +12,11 @@ public partial class LittleEndianStreamReader : EndianStreamReader
         /// </summary>
         public LittleEndianStreamReader(BufferedStreamReader streamReader) : base(streamReader) { }
 
+        /// <summary>
+        /// Constructs a <see cref="EndianStreamReader"/> given an existing stream reader.
+        /// </summary>
+        public LittleEndianStreamReader(BufferedStreamReader streamReader, bool disposeUnderlyingStream = true) : base(streamReader, disposeUnderlyingStream) { }
+
         /// <inheritdoc />
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public override unsafe void Read<T>(out T value) => Reader.Read(out value);

Source/Reloaded.Memory/Streams/Writers/BigEndianMemoryStream.cs

@@ -1,11 +1,5 @@
-using System;
-using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
-using System.IO;
+using System.IO;
 using System.Runtime.CompilerServices;
-using System.Text;
-using Reloaded.Memory.Streams.Readers;
-using Reloaded.Memory.Utilities;
 
 namespace Reloaded.Memory.Streams.Writers
 {
@@ -17,6 +11,9 @@ public partial class BigEndianMemoryStream : EndianMemoryStream
         /// <inheritdoc />
         public BigEndianMemoryStream(ExtendedMemoryStream stream) : base(stream) {}
 
+        /// <inheritdoc />
+        public BigEndianMemoryStream(ExtendedMemoryStream stream, bool disposeUnderlyingStream = true) : base(stream, disposeUnderlyingStream) { }
+
         /// <inheritdoc />
         public override void Write<T>(T[] structure) => Stream.WriteBigEndianPrimitive(structure);
 

Source/Reloaded.Memory/Streams/Writers/EndianMemoryStream.cs

@@ -1,10 +1,6 @@
 using System;
-using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.Runtime.CompilerServices;
-using System.Text;
-using Reloaded.Memory.Utilities;
 
 namespace Reloaded.Memory.Streams.Writers
 {
@@ -18,11 +14,25 @@ public abstract partial class EndianMemoryStream : IDisposable
         /// </summary>
         public ExtendedMemoryStream Stream { get; private set; }
 
+        /// <summary>
+        /// If this is set, the underlying stream will be disposed.
+        /// </summary>
+        public bool DisposeUnderlyingStream { get; private set; } = true;
+
         /// <summary>
         /// Constructs a <see cref="EndianMemoryStream"/> given an existing stream.
         /// </summary>
         protected EndianMemoryStream(ExtendedMemoryStream stream) => Stream = stream;
 
+        /// <summary>
+        /// Constructs a <see cref="EndianMemoryStream"/> given an existing stream.
+        /// </summary>
+        protected EndianMemoryStream(ExtendedMemoryStream stream, bool disposeUnderlyingStream)
+        {
+            Stream = stream;
+            DisposeUnderlyingStream = disposeUnderlyingStream;
+        }
+
         /// <summary/>
         ~EndianMemoryStream()
         {
@@ -32,7 +42,9 @@ public abstract partial class EndianMemoryStream : IDisposable
         /// <inheritdoc/>
         public void Dispose()
         {
-            Stream?.Dispose();
+            if (DisposeUnderlyingStream)
+                Stream?.Dispose();
+            
             GC.SuppressFinalize(this);
         }
 

Source/Reloaded.Memory/Streams/Writers/LittleEndianMemoryStream.cs

@@ -1,9 +1,5 @@
-using System;
-using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
-using System.IO;
+using System.IO;
 using System.Runtime.CompilerServices;
-using System.Text;
 
 namespace Reloaded.Memory.Streams.Writers
 {
@@ -15,6 +11,9 @@ public partial class LittleEndianMemoryStream : EndianMemoryStream
         /// <inheritdoc />
         public LittleEndianMemoryStream(ExtendedMemoryStream stream) : base(stream) { }
 
+        /// <inheritdoc />
+        public LittleEndianMemoryStream(ExtendedMemoryStream stream, bool disposeUnderlyingStream = true) : base(stream, disposeUnderlyingStream) { }
+
         /// <inheritdoc />
         public override void Write<T>(T[] structure) => Stream.Write(structure);