fix: truncate task panel lines to terminal width#3
Open
xuli500177 wants to merge 2 commits into
Open
Conversation
added 2 commits
June 9, 2026 02:48
When a workflow has a long name or phase name, the task panel renders a line exceeding the terminal width, causing pi-tui to crash with 'Rendered line exceeds terminal width'. Changes: - Add width parameter to renderPanel() - Truncate lines that exceed maxWidth - Pass width from Component.render() callback
The hint line uses theme.fg('dim', ...) which adds ANSI escape codes.
Truncating after color application would still exceed terminal width.
Now truncate the plain text first, then apply color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Truncate task panel lines to terminal width
Problem
When a workflow has a long name or phase name, the task panel renders a line exceeding the terminal width, causing pi-tui to crash with:
Root Cause
renderPanel()builds status lines without respecting the terminal width:When
workflowName+phaseis long, the line overflows.Fix
widthfrom theComponent.render()callback torenderPanel()maxWidthThe lines in
rowsare intentionally plain text (no ANSI codes), sostring.lengthis sufficient for width calculation.