fix: repair pre-existing typecheck and lint failures on main

The build/lint/runtime-smoke-test CI jobs were red independent of any
dependency work:

- src/client/ipc.ts: import the `RecordBatch` type (used in three
  signatures but never imported) — TS2304.
- src/client/stream.ts: capture `_stateToken` into a local inside the
  continuation loop so the null-guard narrows it; the class property
  widened back to `string | null` after reassignment — TS2345.
- Apply Biome safe fixes: remove unused imports (the lint errors) and
  organize imports across affected src/test files.

typecheck, biome check, build, and bun/node smoke tests all pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: rustyconover

src/arrow/impl-arrowjs/index.ts

@@ -3,7 +3,9 @@
 import {
   Binary as A_Binary,
   Bool as A_Bool,
+  Data as A_Data,
   type DataType as A_DataType,
+  DataType as A_DataTypeNS,
   DateDay as A_DateDay,
   Decimal as A_Decimal,
   Dictionary as A_Dictionary,
@@ -33,8 +35,6 @@ import {
   Uint32 as A_Uint32,
   Uint64 as A_Uint64,
   Utf8 as A_Utf8,
-  Data as A_Data,
-  DataType as A_DataTypeNS,
   makeData as a_makeData,
   vectorFromArray as a_vectorFromArray,
   RecordBatchReader,

src/client/ipc.ts

@@ -7,14 +7,12 @@ import {
   DataType,
   Float64,
   Int64,
+  type RecordBatch,
   RecordBatchReader,
   type Schema,
   Utf8,
 } from "@query-farm/apache-arrow";
-import {
-  emptyBatchWithMetadata,
-  singleRowBatchWithMetadata,
-} from "#vgi-rpc-arrow";
+import { emptyBatchWithMetadata, singleRowBatchWithMetadata } from "#vgi-rpc-arrow";
 import {
   LOG_EXTRA_KEY,
   LOG_LEVEL_KEY,

src/client/stream.ts

@@ -250,7 +250,9 @@ export class HttpStreamSession implements StreamSession {
 
     // Follow continuation tokens
     while (true) {
-      const responseBody = await this._sendContinuation(this._stateToken);
+      const stateToken = this._stateToken;
+      if (stateToken === null) return;
+      const responseBody = await this._sendContinuation(stateToken);
       const { batches } = await readResponseBatches(responseBody);
 
       let gotContinuation = false;

test/client/ipc-cross-impl.test.ts

@@ -29,21 +29,10 @@
  */
 
 import { describe, expect, it } from "bun:test";
-import {
-  Field,
-  Float64,
-  Schema,
-  Utf8,
-} from "@query-farm/apache-arrow";
-
-import * as flechetteImpl from "../../src/arrow/impl-flechette/index.js";
+import { Field, Float64, Schema, Utf8 } from "@query-farm/apache-arrow";
 import * as arrowjsImpl from "../../src/arrow/impl-arrowjs/index.js";
-import {
-  PROTOCOL_VERSION_KEY,
-  REQUEST_VERSION,
-  REQUEST_VERSION_KEY,
-  RPC_METHOD_KEY,
-} from "../../src/constants.js";
+import * as flechetteImpl from "../../src/arrow/impl-flechette/index.js";
+import { PROTOCOL_VERSION_KEY, REQUEST_VERSION, REQUEST_VERSION_KEY, RPC_METHOD_KEY } from "../../src/constants.js";
 
 const impls = [
   { name: "impl-arrowjs", impl: arrowjsImpl },
@@ -95,11 +84,7 @@ for (const { name, impl } of impls) {
       const schema = new Schema([new Field("name", new Utf8(), true)]);
       const metadata = buildExpectedMetadata("catalog_attach", "1.0.0");
 
-      const batch = impl.singleRowBatchWithMetadata(
-        schema as any,
-        { name: "albemarle_gis" },
-        metadata,
-      );
+      const batch = impl.singleRowBatchWithMetadata(schema as any, { name: "albemarle_gis" }, metadata);
       const bytes = impl.serializeBatches(schema as any, [batch as any]);
       expect(bytes.byteLength).toBeGreaterThan(0);
 
@@ -138,14 +123,9 @@ describe("buildRequestIpc empty-schema regression — apache-arrow batch passed
   // apache-arrow batch doesn't surface that field.
   it("flechette.serializeBatches refuses an apache-arrow RecordBatch", () => {
     const schema = new Schema([]);
-    const apacheBatch = arrowjsImpl.emptyBatchWithMetadata(
-      schema as any,
-      buildExpectedMetadata("__describe__"),
-    );
+    const apacheBatch = arrowjsImpl.emptyBatchWithMetadata(schema as any, buildExpectedMetadata("__describe__"));
 
-    expect(() =>
-      flechetteImpl.serializeBatches(schema as any, [apacheBatch as any]),
-    ).toThrow(); // any throw is fine — the point is that mixing impls is incoherent.
+    expect(() => flechetteImpl.serializeBatches(schema as any, [apacheBatch as any])).toThrow(); // any throw is fine — the point is that mixing impls is incoherent.
   });
 });
 
@@ -172,9 +152,7 @@ describe("introspect.deserializeSchema returns impl-native types", () => {
     // serialized as a Schema IPC message. Both impls' deserializeSchema
     // should accept it and return a type instance whose factory matches
     // their own backend.
-    const apacheSchema = arrowjsImpl.schema([
-      arrowjsImpl.field("request", arrowjsImpl.binary() as any, true),
-    ]);
+    const apacheSchema = arrowjsImpl.schema([arrowjsImpl.field("request", arrowjsImpl.binary() as any, true)]);
     const ipcBytes = arrowjsImpl.serializeSchema(apacheSchema);
 
     // Bun default condition resolves to impl-arrowjs. Re-imports of the
@@ -184,11 +162,7 @@ describe("introspect.deserializeSchema returns impl-native types", () => {
     for (const { name, impl } of impls) {
       const decoded: any = impl.deserializeSchema(ipcBytes);
       const payload = new Uint8Array([1, 2, 3, 4, 5]);
-      const batch = impl.singleRowBatchWithMetadata(
-        decoded,
-        { request: payload },
-        buildExpectedMetadata("test"),
-      );
+      const batch = impl.singleRowBatchWithMetadata(decoded, { request: payload }, buildExpectedMetadata("test"));
       const wire = impl.serializeBatches(decoded, [batch as any]);
       const re: any = impl.deserializeBatch(wire);
       const got = (re.getChildAt ? re.getChildAt(0) : re.getChild?.("request"))?.get?.(0);
@@ -223,9 +197,7 @@ describe("introspect → buildRequestIpc end-to-end (catalog_attach shape)", ()
     it(`${name}: schema-deserialize → binary-encode → re-decode round-trips`, () => {
       // Build the schema (`request: binary`) and emit just-its IPC bytes,
       // matching what the server includes in its __describe__ response.
-      const originalSchema = impl.schema([
-        impl.field("request", impl.binary() as any, true),
-      ]);
+      const originalSchema = impl.schema([impl.field("request", impl.binary() as any, true)]);
       const schemaBytes = impl.serializeSchema(originalSchema);
 
       // Deserialize the schema the way introspect.ts does for paramsSchema.