Skip to content

Release CI implicit release order and transient imports #47

@n13

Description

@n13

This was an attempt at fixing. But other possible fixes are

  • Always release both hdwallet and dilithium crates at the same time
  • Roll them into one crate
  • Do whatever polkadot does to fix

Attempted fix: #42

Problem

hdwallet depends on dilithium and dilithium also pulls hdwallet.

If we release a new version, then one of them gets version bumped but the other doesn't.

This means we always have to build/release dilithium first, and hdwallet after.

In itself, it's not great to have this dependency or order (the other order doesn't work)

Secondly now the new dilithium version is referencing the old HDWallet version, because at the time of the update, hdwallet hasn't yet been updated. The old version gets pulled into cargo.lock. It is not used by dilithium so doesn't cause code errors, but might cause errors in transient dependencies.

So this is a very fragile system.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions