Merge pull request #174 from znzryb/fix-ktor-engine-classloader-clash

Fix analytics ServiceConfigurationError on IDEs that bundle their own ktor (2025.2+/2026.1)

Author: Pushpavel

src/main/kotlin/com/github/pushpavel/autocp/common/analytics/GoogleAnalytics.kt

@@ -9,6 +9,7 @@ import com.intellij.openapi.application.ApplicationInfo
 import com.intellij.openapi.components.Service
 import com.intellij.openapi.util.SystemInfo
 import io.ktor.client.*
+import io.ktor.client.engine.java.*
 import io.ktor.client.plugins.observer.*
 import io.ktor.client.request.*
 import io.ktor.client.statement.*
@@ -21,40 +22,52 @@ class GoogleAnalytics {
 
     private val scope = ioScope()
 
-    private val httpClient = HttpClient {
-        expectSuccess = false
-        ResponseObserver { response ->
-            println("HTTP status: ${response.status.value}\n${response.bodyAsText()}")
+    // The engine must be named explicitly: engine auto-discovery goes through
+    // java.util.ServiceLoader, and on IDEs whose platform bundles its own ktor
+    // (2025.2+ ships ktor-client-cio in lib/) the lookup finds the platform's
+    // CIOEngineContainer, which implements the platform copy of the interface,
+    // not ours — ServiceConfigurationError: "... not a subtype".
+    private val httpClient by lazy {
+        HttpClient(Java) {
+            expectSuccess = false
+            ResponseObserver { response ->
+                println("HTTP status: ${response.status.value}\n${response.bodyAsText()}")
+            }
         }
     }
 
     fun sendEvent(event: Event) {
         scope.launch {
-            httpClient.post("${R.keys.analyticsEndPoint}?measurement_id=${R.keys.analyticsMeasurementId}&api_secret=${R.keys.analyticsApiSecret}") {
-                contentType(ContentType.Application.Json)
-                setBody(buildJsonObject {
-                    put("client_id", PropertiesComponent.getInstance().analyticsClientId)
-                    putJsonObject("user_properties") {
-                        putJsonObject("os") {
-                            put("value", SystemInfo.getOsNameAndVersion())
-                        }
-                        putJsonObject("productCode") {
-                            put("value", ApplicationInfo.getInstance().build.productCode)
-                        }
-                        putJsonObject("productVersion") {
-                            put("value", ApplicationInfo.getInstance().build.asStringWithoutProductCodeAndSnapshot())
-                        }
-                        putJsonObject("version") {
-                            // avoid PluginId.getId: it compiles to a PluginId.Companion reference that older IDEs (< 2025.2) don't have
-                            put("value", PluginManagerCore.plugins.find { it.pluginId.idString == R.keys.pluginId }?.version)
-                        }
+            // analytics must never surface an IDE error, whatever goes wrong
+            runCatching { postEvent(event) }
+        }
+    }
+
+    private suspend fun postEvent(event: Event) {
+        httpClient.post("${R.keys.analyticsEndPoint}?measurement_id=${R.keys.analyticsMeasurementId}&api_secret=${R.keys.analyticsApiSecret}") {
+            contentType(ContentType.Application.Json)
+            setBody(buildJsonObject {
+                put("client_id", PropertiesComponent.getInstance().analyticsClientId)
+                putJsonObject("user_properties") {
+                    putJsonObject("os") {
+                        put("value", SystemInfo.getOsNameAndVersion())
                     }
-                    put("non_personalized_ads", true)
-                    putJsonArray("events") {
-                        addJsonObject { event.buildJsonObj(this) }
+                    putJsonObject("productCode") {
+                        put("value", ApplicationInfo.getInstance().build.productCode)
                     }
-                }.toString().also { println(it) }.encodeToByteArray())
-            }
+                    putJsonObject("productVersion") {
+                        put("value", ApplicationInfo.getInstance().build.asStringWithoutProductCodeAndSnapshot())
+                    }
+                    putJsonObject("version") {
+                        // avoid PluginId.getId: it compiles to a PluginId.Companion reference that older IDEs (< 2025.2) don't have
+                        put("value", PluginManagerCore.plugins.find { it.pluginId.idString == R.keys.pluginId }?.version)
+                    }
+                }
+                put("non_personalized_ads", true)
+                putJsonArray("events") {
+                    addJsonObject { event.buildJsonObj(this) }
+                }
+            }.toString().also { println(it) }.encodeToByteArray())
         }
     }