♻️ refactor(node-utils): rename TestResult to TestResponse in use case specs

Align the abstract use case test doubles with the Response naming convention so they
satisfy the use-case-architecture-patterns rule.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: cteyton

packages/node-utils/src/application/AbstractAdminUseCase.spec.ts

@@ -16,25 +16,25 @@ import {
   UserNotInOrganizationError,
 } from './UserAccessErrors';
 
-type TestResult = PackmindResult & { success: boolean };
+type TestResponse = PackmindResult & { success: boolean };
 
 class TestAdminUseCase extends AbstractAdminUseCase<
   PackmindCommand,
-  TestResult
+  TestResponse
 > {
   constructor(
     accountsPort: IAccountsPort,
     logger: ReturnType<typeof stubLogger>,
     private readonly onExecute: (
       command: PackmindCommand & AdminContext,
-    ) => Promise<TestResult>,
+    ) => Promise<TestResponse>,
   ) {
     super(accountsPort, logger);
   }
 
   protected executeForAdmins(
     command: PackmindCommand & AdminContext,
-  ): Promise<TestResult> {
+  ): Promise<TestResponse> {
     return this.onExecute(command);
   }
 }
@@ -51,7 +51,7 @@ describe('AbstractAdminUseCase', () => {
   let mockGetUserById: jest.Mock;
   let mockGetOrganizationById: jest.Mock;
   let mockExecuteForAdmins: jest.MockedFunction<
-    (command: PackmindCommand & AdminContext) => Promise<TestResult>
+    (command: PackmindCommand & AdminContext) => Promise<TestResponse>
   >;
   let logger: ReturnType<typeof stubLogger>;
   let useCase: TestAdminUseCase;
@@ -87,7 +87,7 @@ describe('AbstractAdminUseCase', () => {
     mockGetUserById = jest.fn();
     mockGetOrganizationById = jest.fn();
     mockExecuteForAdmins = jest
-      .fn<Promise<TestResult>, [PackmindCommand & AdminContext]>()
+      .fn<Promise<TestResponse>, [PackmindCommand & AdminContext]>()
       .mockResolvedValue({ success: true });
     logger = stubLogger();
 
@@ -108,7 +108,7 @@ describe('AbstractAdminUseCase', () => {
       let user: User;
       let organization: Organization;
       let membership: UserOrganizationMembership;
-      let result: TestResult;
+      let result: TestResponse;
 
       beforeEach(async () => {
         user = buildUser();
@@ -147,7 +147,7 @@ describe('AbstractAdminUseCase', () => {
       let user: User;
       let organization: Organization;
       let membership: UserOrganizationMembership;
-      let result: TestResult;
+      let result: TestResponse;
 
       beforeEach(async () => {
         const otherOrganizationId = createOrganizationId('other-organization');

packages/node-utils/src/application/AbstractMemberUseCase.spec.ts

@@ -15,25 +15,25 @@ import {
   UserNotInOrganizationError,
 } from './UserAccessErrors';
 
-type TestResult = PackmindResult & { success: boolean };
+type TestResponse = PackmindResult & { success: boolean };
 
 class TestMemberUseCase extends AbstractMemberUseCase<
   PackmindCommand,
-  TestResult
+  TestResponse
 > {
   constructor(
     accountsPort: IAccountsPort,
     logger: ReturnType<typeof stubLogger>,
     private readonly onExecute: (
       command: PackmindCommand & MemberContext,
-    ) => Promise<TestResult>,
+    ) => Promise<TestResponse>,
   ) {
     super(accountsPort, logger);
   }
 
   protected executeForMembers(
     command: PackmindCommand & MemberContext,
-  ): Promise<TestResult> {
+  ): Promise<TestResponse> {
     return this.onExecute(command);
   }
 }
@@ -50,7 +50,7 @@ describe('AbstractMemberUseCase', () => {
   let mockGetUserById: jest.Mock;
   let mockGetOrganizationById: jest.Mock;
   let mockExecuteForMembers: jest.MockedFunction<
-    (command: PackmindCommand & MemberContext) => Promise<TestResult>
+    (command: PackmindCommand & MemberContext) => Promise<TestResponse>
   >;
   let logger: ReturnType<typeof stubLogger>;
   let useCase: TestMemberUseCase;
@@ -92,7 +92,7 @@ describe('AbstractMemberUseCase', () => {
     mockGetUserById = jest.fn();
     mockGetOrganizationById = jest.fn();
     mockExecuteForMembers = jest
-      .fn<Promise<TestResult>, [PackmindCommand & MemberContext]>()
+      .fn<Promise<TestResponse>, [PackmindCommand & MemberContext]>()
       .mockResolvedValue({ success: true });
     logger = stubLogger();
 
@@ -116,7 +116,7 @@ describe('AbstractMemberUseCase', () => {
     let user: User;
     let organization: Organization;
     let membership: UserOrganizationMembership;
-    let result: TestResult;
+    let result: TestResponse;
 
     beforeEach(async () => {
       user = buildUser();
@@ -155,7 +155,7 @@ describe('AbstractMemberUseCase', () => {
     let user: User;
     let organization: Organization;
     let membership: UserOrganizationMembership;
-    let result: TestResult;
+    let result: TestResponse;
 
     beforeEach(async () => {
       user = buildUser({

packages/node-utils/src/application/AbstractSpaceAdminUseCase.spec.ts

@@ -23,26 +23,26 @@ import {
   UserNotInOrganizationError,
 } from './UserAccessErrors';
 
-type TestResult = PackmindResult & { success: boolean };
+type TestResponse = PackmindResult & { success: boolean };
 
 class TestSpaceAdminUseCase extends AbstractSpaceAdminUseCase<
   SpaceAdminCommand,
-  TestResult
+  TestResponse
 > {
   constructor(
     spacesPort: ISpacesPort,
     accountsPort: IAccountsPort,
     logger: ReturnType<typeof stubLogger>,
     private readonly onExecute: (
       command: SpaceAdminCommand & SpaceAdminContext,
-    ) => Promise<TestResult>,
+    ) => Promise<TestResponse>,
   ) {
     super(spacesPort, accountsPort, logger);
   }
 
   protected executeForSpaceAdmins(
     command: SpaceAdminCommand & SpaceAdminContext,
-  ): Promise<TestResult> {
+  ): Promise<TestResponse> {
     return this.onExecute(command);
   }
 }
@@ -62,7 +62,7 @@ describe('AbstractSpaceAdminUseCase', () => {
   let mockGetUserById: jest.Mock;
   let mockGetOrganizationById: jest.Mock;
   let mockExecuteForSpaceAdmins: jest.MockedFunction<
-    (command: SpaceAdminCommand & SpaceAdminContext) => Promise<TestResult>
+    (command: SpaceAdminCommand & SpaceAdminContext) => Promise<TestResponse>
   >;
   let logger: ReturnType<typeof stubLogger>;
   let useCase: TestSpaceAdminUseCase;
@@ -110,7 +110,7 @@ describe('AbstractSpaceAdminUseCase', () => {
     mockGetUserById = jest.fn();
     mockGetOrganizationById = jest.fn();
     mockExecuteForSpaceAdmins = jest
-      .fn<Promise<TestResult>, [SpaceAdminCommand & SpaceAdminContext]>()
+      .fn<Promise<TestResponse>, [SpaceAdminCommand & SpaceAdminContext]>()
       .mockResolvedValue({ success: true });
     logger = stubLogger();
 
@@ -137,7 +137,7 @@ describe('AbstractSpaceAdminUseCase', () => {
 
   describe('execute', () => {
     describe('when the caller is a space admin', () => {
-      let result: TestResult;
+      let result: TestResponse;
 
       beforeEach(async () => {
         mockGetUserById.mockResolvedValue(buildUser());

packages/node-utils/src/application/AbstractSpaceMemberUseCase.spec.ts

@@ -23,26 +23,26 @@ import {
   UserNotInOrganizationError,
 } from './UserAccessErrors';
 
-type TestResult = PackmindResult & { success: boolean };
+type TestResponse = PackmindResult & { success: boolean };
 
 class TestSpaceMemberUseCase extends AbstractSpaceMemberUseCase<
   SpaceMemberCommand,
-  TestResult
+  TestResponse
 > {
   constructor(
     spacesPort: ISpacesPort,
     accountsPort: IAccountsPort,
     logger: ReturnType<typeof stubLogger>,
     private readonly onExecute: (
       command: SpaceMemberCommand & SpaceMemberContext,
-    ) => Promise<TestResult>,
+    ) => Promise<TestResponse>,
   ) {
     super(spacesPort, accountsPort, logger);
   }
 
   protected executeForSpaceMembers(
     command: SpaceMemberCommand & SpaceMemberContext,
-  ): Promise<TestResult> {
+  ): Promise<TestResponse> {
     return this.onExecute(command);
   }
 }
@@ -62,7 +62,7 @@ describe('AbstractSpaceMemberUseCase', () => {
   let mockGetUserById: jest.Mock;
   let mockGetOrganizationById: jest.Mock;
   let mockExecuteForSpaceMembers: jest.MockedFunction<
-    (command: SpaceMemberCommand & SpaceMemberContext) => Promise<TestResult>
+    (command: SpaceMemberCommand & SpaceMemberContext) => Promise<TestResponse>
   >;
   let logger: ReturnType<typeof stubLogger>;
   let useCase: TestSpaceMemberUseCase;
@@ -110,7 +110,7 @@ describe('AbstractSpaceMemberUseCase', () => {
     mockGetUserById = jest.fn();
     mockGetOrganizationById = jest.fn();
     mockExecuteForSpaceMembers = jest
-      .fn<Promise<TestResult>, [SpaceMemberCommand & SpaceMemberContext]>()
+      .fn<Promise<TestResponse>, [SpaceMemberCommand & SpaceMemberContext]>()
       .mockResolvedValue({ success: true });
     logger = stubLogger();
 
@@ -137,7 +137,7 @@ describe('AbstractSpaceMemberUseCase', () => {
 
   describe('execute', () => {
     describe('when the caller is a space member', () => {
-      let result: TestResult;
+      let result: TestResponse;
 
       beforeEach(async () => {
         mockGetUserById.mockResolvedValue(buildUser());
@@ -159,7 +159,7 @@ describe('AbstractSpaceMemberUseCase', () => {
     });
 
     describe('when the caller is a space admin', () => {
-      let result: TestResult;
+      let result: TestResponse;
 
       beforeEach(async () => {
         mockGetUserById.mockResolvedValue(buildUser());