Merge pull request #448 from Sharpie/backport-fix-rubocop-1862-lint

8.x Backport: Fix rubocop 1.86.2 lint

Author: Sharpie

lib/puppet/pops/lookup/sub_lookup.rb

@@ -21,6 +21,8 @@ module SubLookup
   def split_key(key)
     return [key] if key.match(SPECIAL).nil?
 
+    # Rubocop 1.86.2 starts mis-classifying the "raise yield" constructions as a failure.
+    # rubocop:disable Lint/ParenthesesAsGroupedExpression
     segments = key.split(/(\s*"[^"]+"\s*|\s*'[^']+'\s*|[^'".]+)/)
     if segments.empty?
       # Only happens if the original key was an empty string
@@ -45,6 +47,7 @@ def split_key(key)
     else
       raise yield('Syntax error')
     end
+    # rubocop:enable Lint/ParenthesesAsGroupedExpression
   end
 
   # Perform a sub-lookup using the given _segments_ to access the given _value_. Each segment must be a string. A string

lib/puppet/util/fileparsing.rb

@@ -103,13 +103,13 @@ def initialize(type,
     # Convert a record into a line by joining the fields together appropriately.
     # This is pulled into a separate method so it can be called by the hooks.
     def join(details)
-      joinchar = self.joiner
+      joinchar = joiner
 
       fields.filter_map { |field|
         # If the field is marked absent, use the appropriate replacement
         if details[field] == :absent or details[field] == [:absent] or details[field].nil?
-          if self.optional.include?(field)
-            self.absent
+          if optional.include?(field)
+            absent
           else
             raise ArgumentError, _("Field '%{field}' is required") % { field: field }
           end