Skip to content

Upstream UEFI SMBIOS constants to r-efi #1457

@kat-perez

Description

@kat-perez

Description

Several UEFI specification-defined constants are currently defined locally in the patina_smbios crate rather than being sourced from r-efi. These should be upstreamed to r-efi so they are available to the broader UEFI Rust ecosystem.

From PR #1447 review:

"for these various UEFI spec defined things, we should be taking them to r-efi as well. Hosting them here until they are merged there is fine."

Already upstreamed

  • EFI_GLOBAL_VARIABLE GUID — r-efi #93
  • LOAD_OPTION_* attribute constants — r-efi #93
  • EFI_DEBUG_IMAGE_INFO_TABLE constants — r-efi 1c6682e

To upstream

SMBIOS constants currently defined locally in patina_smbios that need to land in r-efi:

  • SmbiosProtocol::PROTOCOL_GUID (manager/protocol.rs:51) — EDK2 SMBIOS protocol GUID
  • SMBIOS_HANDLE_PI_RESERVED = 0xFFFE (service.rs:30) — reserved handle for auto-assignment
  • SMBIOS_STRING_MAX_LENGTH = 64 (service.rs:33) — max string length

Switch to r-efi

Already in r-efi; patina should drop the local definition and use the upstream one:

  • SMBIOS_3_X_TABLE_GUID (manager/core.rs:38) → use r_efi::system::SMBIOS3_TABLE_GUID

References

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

Status
In Progress
Status
Todo

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions