Skip to content

fix(grpo): minor issues (regex whitespace, CoT adapter reuse, shutil import) #50

Description

@abrichr

Collection of Small Issues

  1. CLICK regex (trainer.py:761) doesn't handle whitespace variants: CLICK( x=0.5, y=0.5 ) won't match. Add optional whitespace: CLICK\s*\(.

  2. CoT warmup (cot_warmup.py:93) creates a new API adapter per step inside the annotation loop. Should be hoisted outside the loop.

  3. import shutil inside save_checkpoint() is re-imported every call (minor).

  4. Port mismatch: GRPOConfig.server_url defaults to port 5001 but WAALiveConfig defaults to 5000 — document this difference or unify the default.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions