Keep stop-focus color when a vehicle is selected (#1893 regression) (#1899)

#1893 routed every vehicle selection through publishMapPresentation(), whose
new selected-trip branch always drew the exact trip in the route's GTFS color
(currentRouteColor()) over a generic direction underlay. Inside stop focus,
where the emphasized route is drawn in its adjacency color, tapping a vehicle
therefore reverted the route to its GTFS hue and layered the trip over the
generic route-direction geometry — reading as standalone route mode.

Resolve the selected trip's color from the adjacency palette
(routeColors[selected.routeDirection]) when the route is emphasized in stop
focus, falling back to the GTFS color only in whole-route mode where no
adjacency entry exists. In that emphasized case also drop the generic
direction underlay: the adjacency-colored trip already reads on its own, and
the underlay is what made it look like route mode. Whole-route standalone
selection is unchanged (GTFS trip + underlay).

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: bmander

onebusaway-android/src/main/java/org/onebusaway/android/map/RouteMapController.kt

@@ -598,21 +598,27 @@ class RouteMapController(
             focusedGeometry.toRouteBadges(focusedRoutes, routeColors)
         } else emptyList()
         val selected = selectedTripPresentation()
+        // A route emphasized inside stop focus carries an adjacency color (keyed on the focused stop's
+        // trips); the selected trip keeps that color so selecting a vehicle doesn't drop the route back
+        // to its GTFS hue. In whole-route mode there is no adjacency entry, so fall back to GTFS.
+        val selectedAdjacencyColor = selected?.let { routeColors[it.routeDirection] }
         val selectedTrip = selected?.points
             ?.takeIf { it.size >= 2 }
             ?.let { points ->
-                focusedRoutePolyline(currentRouteColor(), points, directional = true)
+                focusedRoutePolyline(selectedAdjacencyColor ?: currentRouteColor(), points, directional = true)
             }
-        // A selected vehicle shows its exact trip everywhere: the trip line over its thin
-        // same-direction underlay (with any focused-stop siblings beneath), framed to that trip,
-        // and only its scheduled stops. In whole-route mode the empty [focusedGeometry] collapses
-        // toTripFocusedRoutePolylines to just the underlay + trip.
+        // A selected vehicle shows its exact trip everywhere: the trip line, framed to that trip, over
+        // its scheduled stops. In whole-route mode it sits on a thin same-direction underlay; inside
+        // stop focus the emphasized route already reads via its adjacency color, so the generic
+        // direction underlay is dropped (it would otherwise look like standalone route mode) and only
+        // the focused-stop siblings remain beneath the exact trip.
         if (selected != null && selectedTrip != null) {
             renderState.setRoutePolylines(
                 polylines = focusedGeometry.toTripFocusedRoutePolylines(
                     selected.routeDirection,
                     routeColors,
-                    selectedDirectionUnderlay(selected.routeDirection.directionId),
+                    if (selectedAdjacencyColor != null) emptyList()
+                    else selectedDirectionUnderlay(selected.routeDirection.directionId),
                     selectedTrip,
                 ),
                 framingPolylines = listOf(selectedTrip),