[MIG] event_sale_reservation: Migration to 18.0

Author: BhaveshHeliconia

event_sale_reservation/README.rst

@@ -17,13 +17,13 @@ Sell event reservations
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fevent-lightgray.png?logo=github
-    :target: https://github.com/OCA/event/tree/17.0/event_sale_reservation
+    :target: https://github.com/OCA/event/tree/18.0/event_sale_reservation
     :alt: OCA/event
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/event-17-0/event-17-0-event_sale_reservation
+    :target: https://translation.odoo-community.org/projects/event-18-0/event-18-0-event_sale_reservation
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/event&target_branch=17.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/event&target_branch=18.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -125,7 +125,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/event/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/event/issues/new?body=module:%20event_sale_reservation%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/event/issues/new?body=module:%20event_sale_reservation%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -145,6 +145,10 @@ Contributors
   - Jairo Llopis
   - Pilar Vargas
 
+- `Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>`__
+
+  - Bhavesh Heliconia
+
 Maintainers
 -----------
 
@@ -166,6 +170,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-pilarvargas-tecnativa| 
 
-This module is part of the `OCA/event <https://github.com/OCA/event/tree/17.0/event_sale_reservation>`_ project on GitHub.
+This module is part of the `OCA/event <https://github.com/OCA/event/tree/18.0/event_sale_reservation>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

event_sale_reservation/__manifest__.py

@@ -4,7 +4,7 @@
 {
     "name": "Sell event reservations",
     "summary": "Allow selling event registrations before the event exists",
-    "version": "17.0.1.0.1",
+    "version": "18.0.1.0.0",
     "development_status": "Mature",
     "category": "Marketing",
     "website": "https://github.com/OCA/event",
@@ -14,6 +14,7 @@
     "application": False,
     "installable": True,
     "depends": [
+        "product",
         "event_sale",
     ],
     "data": [

event_sale_reservation/models/event_type.py

@@ -24,14 +24,14 @@ def _seats_reservation_domain(self):
         return [
             ("event_reservation_type_id", "in", self.ids),
             ("order_id.state", "in", ("sale", "done")),
-            ("product_id.detailed_type", "=", "event_reservation"),
+            ("product_id.type", "=", "event_reservation"),
         ]
 
     @api.depends(
         "reserved_sale_order_line_ids.event_registration_count",
         "reserved_sale_order_line_ids.event_reservation_type_id",
         "reserved_sale_order_line_ids.order_id.state",
-        "reserved_sale_order_line_ids.product_id.detailed_type",
+        "reserved_sale_order_line_ids.product_id.type",
         "reserved_sale_order_line_ids.product_uom_qty",
     )
     def _compute_reservations_total(self):

event_sale_reservation/models/product_template.py

@@ -2,15 +2,15 @@
 # Copyright 2023 Tecnativa - Víctor Martínez
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 
 from ..exceptions import ReservationWithoutEventTypeError
 
 
 class ProductTemplate(models.Model):
     _inherit = "product.template"
 
-    detailed_type = fields.Selection(
+    type = fields.Selection(
         selection_add=[
             ("event_reservation", "Event Reservation"),
         ],
@@ -28,17 +28,17 @@ def _detailed_type_mapping(self):
         type_mapping["event_reservation"] = "service"
         return type_mapping
 
-    @api.constrains("detailed_type")
+    @api.constrains("type")
     def _check_event_reservation(self):
         """Event reservation products checks.
 
         - A product cannot be both an event ticket and an event reservation.
         - An event reservation must have an event type attached.
         """
         for one in self:
-            if one.detailed_type != "event_reservation":
+            if one.type != "event_reservation":
                 continue
             if not one.event_reservation_type_id:
                 raise ReservationWithoutEventTypeError(
-                    _("You must indicate event type for %(name)s.")
+                    self.env._("You must indicate event type for %(name)s.")
                 )

event_sale_reservation/models/sale_order.py

@@ -26,7 +26,7 @@ def _compute_event_reservations_pending(self):
         """Know how many pending event reservations are linked to this SO."""
         for one in self:
             reservation_lines = one.order_line.filtered(
-                lambda x: x.product_id.detailed_type == "event_reservation"
+                lambda x: x.product_id.type == "event_reservation"
             )
             reserved = sum(reservation_lines.mapped("product_uom_qty"))
             registered = sum(reservation_lines.mapped("event_registration_count"))
@@ -47,5 +47,5 @@ def action_open_event_registrations(self):
             "name": _("Attendees"),
             "res_model": "event.registration",
             "type": "ir.actions.act_window",
-            "view_mode": "tree,form,calendar,graph",
+            "view_mode": "list,form,calendar,graph",
         }

event_sale_reservation/readme/CONTRIBUTORS.md

@@ -1,3 +1,5 @@
 - [Tecnativa](https://www.tecnativa.com):
   - Jairo Llopis
   - Pilar Vargas
+- [Heliconia Solutions Pvt. Ltd.](https://www.heliconia.io)
+  - Bhavesh Heliconia

event_sale_reservation/static/description/index.html

@@ -369,7 +369,7 @@ <h1 class="title">Sell event reservations</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:e23d10fe39515a6cb80887303de1d063a1499d06b4b00f70cd139646101d3a9c
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Mature" src="https://img.shields.io/badge/maturity-Mature-brightgreen.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/event/tree/17.0/event_sale_reservation"><img alt="OCA/event" src="https://img.shields.io/badge/github-OCA%2Fevent-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/event-17-0/event-17-0-event_sale_reservation"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/event&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Mature" src="https://img.shields.io/badge/maturity-Mature-brightgreen.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/event/tree/18.0/event_sale_reservation"><img alt="OCA/event" src="https://img.shields.io/badge/github-OCA%2Fevent-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/event-18-0/event-18-0-event_sale_reservation"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/event&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module extends the functionality of event_sale to support selling
 reservations of events that still don’t exist and to allow you to
 schedule the creation of events based on how many reservations already
@@ -469,7 +469,7 @@ <h1><a class="toc-backref" href="#toc-entry-4">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/event/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/event/issues/new?body=module:%20event_sale_reservation%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/event/issues/new?body=module:%20event_sale_reservation%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -488,6 +488,10 @@ <h2><a class="toc-backref" href="#toc-entry-7">Contributors</a></h2>
 <li>Pilar Vargas</li>
 </ul>
 </li>
+<li><a class="reference external" href="https://www.heliconia.io">Heliconia Solutions Pvt. Ltd.</a><ul>
+<li>Bhavesh Heliconia</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
@@ -501,7 +505,7 @@ <h2><a class="toc-backref" href="#toc-entry-8">Maintainers</a></h2>
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/pilarvargas-tecnativa"><img alt="pilarvargas-tecnativa" src="https://github.com/pilarvargas-tecnativa.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/event/tree/17.0/event_sale_reservation">OCA/event</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/event/tree/18.0/event_sale_reservation">OCA/event</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

event_sale_reservation/tests/test_event_sale.py

@@ -3,7 +3,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 from datetime import datetime, timedelta
 
-from odoo.tests.common import Form
+from odoo.tests import Form
 
 from odoo.addons.base.tests.common import BaseCommon
 
@@ -21,7 +21,7 @@ def setUpClass(cls):
         cls.products = cls.env["product.product"].create(
             [
                 {
-                    "detailed_type": "event_reservation",
+                    "type": "event_reservation",
                     "event_reservation_type_id": cls.event_types[num].id,
                     "list_price": num,
                     "name": "product reservation for event type %d" % num,
@@ -111,7 +111,7 @@ def test_wrong_product_reservation_without_type(self):
         with self.assertRaises(ReservationWithoutEventTypeError):
             self.env["product.product"].create(
                 {
-                    "detailed_type": "event_reservation",
+                    "type": "event_reservation",
                     "list_price": 10,
                     "name": "event reservation without event type fails",
                 }

event_sale_reservation/views/event_type_view.xml

@@ -34,12 +34,12 @@
         <field name="model">event.type</field>
         <field name="inherit_id" ref="event.view_event_type_tree" />
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field
                     name="seats_reservation_total"
                     groups="sales_team.group_sale_salesman"
                 />
-            </tree>
+            </list>
         </field>
     </record>
 </data>

event_sale_reservation/views/product_template_view.xml

@@ -7,11 +7,11 @@
         <field name="model">product.template</field>
         <field name="inherit_id" ref="product.product_template_form_view" />
         <field name="arch" type="xml">
-            <field name="detailed_type" position="after">
+            <field name="type" position="after">
                 <field
                     name="event_reservation_type_id"
-                    invisible="detailed_type != 'event_reservation'"
-                    required="detailed_type == 'event_reservation'"
+                    invisible="type != 'event_reservation'"
+                    required="type == 'event_reservation'"
                     groups="event.group_event_user"
                 />
             </field>