fix CI: resolve editor type errors, fix test discovery, and field validation bug

- Make registerEditorBlock generic to fix BlockEditProps type variance errors
- Add @types/node to editor package for process global
- Fix BlockData | undefined assertion in editor-state splice
- Replace --dir with positional path filter in CI vitest commands
- Split test helpers from DB-dependent setup so unit tests skip PrismaClient
- Remove global setupFiles from vitest config
- Reject empty strings for required TEXT fields in field-validator

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: AminMemariani

.github/workflows/ci.yml

@@ -56,9 +56,7 @@ jobs:
       - name: Generate Prisma client
         run: pnpm --filter @nextpress/db exec prisma generate
       - name: Run unit tests with coverage
-        run: pnpm --filter @nextpress/core exec vitest run --reporter=verbose --coverage --dir src/__tests__/unit
-        env:
-          SKIP_DB: "true"
+        run: pnpm --filter @nextpress/core exec vitest run --reporter=verbose --coverage src/__tests__/unit
         continue-on-error: true
       - name: Upload coverage to Codecov
         if: always()
@@ -107,7 +105,7 @@ jobs:
       - name: Push schema to test database
         run: pnpm --filter @nextpress/db exec prisma db push --skip-generate
       - name: Run integration tests
-        run: pnpm --filter @nextpress/core exec vitest run --reporter=verbose --dir src/__tests__/integration
+        run: pnpm --filter @nextpress/core exec vitest run --reporter=verbose src/__tests__/integration
         continue-on-error: true
 
   # ── Gate ──

packages/core/src/__tests__/helpers.ts

@@ -0,0 +1,56 @@
+/**
+ * Test helpers — pure utilities that do NOT require a database connection.
+ * Use this in unit tests. Integration tests should import from "./setup".
+ */
+
+import type { AuthContext, PermissionSlug } from "../auth/auth-types";
+
+/** Create a mock AuthContext for testing */
+export function mockAuth(overrides: Partial<AuthContext> = {}): AuthContext {
+  return {
+    user: {
+      id: "test-user-id",
+      email: "test@example.com",
+      name: "Test User",
+      displayName: "Test User",
+      image: null,
+    },
+    siteId: "test-site-id",
+    role: "admin",
+    permissions: new Set<PermissionSlug>([
+      "create_content", "edit_own_content", "edit_others_content",
+      "delete_own_content", "delete_others_content", "publish_content",
+      "manage_categories", "manage_tags", "upload_media", "delete_media",
+      "moderate_comments", "list_users", "create_users", "edit_users",
+      "delete_users", "promote_users", "switch_themes", "customize_theme",
+      "manage_menus", "activate_plugins", "manage_plugins", "manage_settings",
+      "manage_content_types", "manage_fields", "manage_taxonomies",
+      "manage_sites", "read", "edit_profile",
+    ]),
+    ...overrides,
+  };
+}
+
+/** Create a contributor auth (limited permissions) */
+export function mockContributorAuth(): AuthContext {
+  return mockAuth({
+    role: "contributor",
+    permissions: new Set<PermissionSlug>([
+      "create_content", "edit_own_content", "delete_own_content",
+      "read", "edit_profile",
+    ]),
+  });
+}
+
+/** Create an editor auth */
+export function mockEditorAuth(): AuthContext {
+  return mockAuth({
+    role: "editor",
+    permissions: new Set<PermissionSlug>([
+      "create_content", "edit_own_content", "edit_others_content",
+      "delete_own_content", "delete_others_content", "publish_content",
+      "manage_categories", "manage_tags", "upload_media", "delete_media",
+      "moderate_comments", "list_users", "manage_menus", "read", "edit_profile",
+    ]),
+  });
+}

packages/core/src/__tests__/setup.ts

@@ -4,12 +4,13 @@
  * Provides:
  *   - Test database connection (uses TEST_DATABASE_URL)
  *   - Database cleanup between tests
- *   - Mock auth context factory
- *   - Common test fixtures
+ *   - Mock auth context factory (re-exported from helpers)
  */
 
 import { PrismaClient } from "@prisma/client";
-import type { AuthContext, PermissionSlug } from "../auth/auth-types";
+
+// Re-export helpers so existing integration test imports keep working
+export { mockAuth, mockContributorAuth, mockEditorAuth } from "./helpers";
 
 // ── Test database ──
 
@@ -18,66 +19,13 @@ export const testPrisma = new PrismaClient({
 });
 
 beforeAll(async () => {
-  // Verify connection
   await testPrisma.$connect();
 });
 
 afterAll(async () => {
   await testPrisma.$disconnect();
 });
 
-// ── Test helpers ──
-
-/** Create a mock AuthContext for testing */
-export function mockAuth(overrides: Partial<AuthContext> = {}): AuthContext {
-  return {
-    user: {
-      id: "test-user-id",
-      email: "test@example.com",
-      name: "Test User",
-      displayName: "Test User",
-      image: null,
-    },
-    siteId: "test-site-id",
-    role: "admin",
-    permissions: new Set<PermissionSlug>([
-      "create_content", "edit_own_content", "edit_others_content",
-      "delete_own_content", "delete_others_content", "publish_content",
-      "manage_categories", "manage_tags", "upload_media", "delete_media",
-      "moderate_comments", "list_users", "create_users", "edit_users",
-      "delete_users", "promote_users", "switch_themes", "customize_theme",
-      "manage_menus", "activate_plugins", "manage_plugins", "manage_settings",
-      "manage_content_types", "manage_fields", "manage_taxonomies",
-      "manage_sites", "read", "edit_profile",
-    ]),
-    ...overrides,
-  };
-}
-
-/** Create a contributor auth (limited permissions) */
-export function mockContributorAuth(): AuthContext {
-  return mockAuth({
-    role: "contributor",
-    permissions: new Set<PermissionSlug>([
-      "create_content", "edit_own_content", "delete_own_content",
-      "read", "edit_profile",
-    ]),
-  });
-}
-
-/** Create an editor auth */
-export function mockEditorAuth(): AuthContext {
-  return mockAuth({
-    role: "editor",
-    permissions: new Set<PermissionSlug>([
-      "create_content", "edit_own_content", "edit_others_content",
-      "delete_own_content", "delete_others_content", "publish_content",
-      "manage_categories", "manage_tags", "upload_media", "delete_media",
-      "moderate_comments", "list_users", "manage_menus", "read", "edit_profile",
-    ]),
-  });
-}
-
 /** Clean up test data between tests */
 export async function cleanDatabase() {
   const tables = [

packages/core/src/__tests__/unit/permissions.test.ts

@@ -13,7 +13,7 @@ import {
   canPublishContent,
   canAccessAdmin,
 } from "../../auth/permissions";
-import { mockAuth, mockContributorAuth, mockEditorAuth } from "../setup";
+import { mockAuth, mockContributorAuth, mockEditorAuth } from "../helpers";
 
 describe("can()", () => {
   it("grants permission when role has it", () => {

packages/core/src/fields/field-validator.ts

@@ -26,6 +26,7 @@ export function zodSchemaForField(def: FieldDefinition): z.ZodTypeAny {
   switch (def.fieldType) {
     case "TEXT": {
       let s = z.string();
+      if (def.isRequired && typeof v.minLength !== "number") s = s.min(1);
       if (typeof v.minLength === "number") s = s.min(v.minLength);
       if (typeof v.maxLength === "number") s = s.max(v.maxLength);
       if (typeof v.pattern === "string") s = s.regex(new RegExp(v.pattern));

packages/core/vitest.config.ts

@@ -5,7 +5,6 @@ export default defineConfig({
   test: {
     globals: true,
     environment: "node",
-    setupFiles: ["./src/__tests__/setup.ts"],
     include: ["src/__tests__/**/*.test.ts"],
     coverage: {
       provider: "v8",

packages/editor/package.json

@@ -11,6 +11,7 @@
     "zod": "^3.23.0"
   },
   "devDependencies": {
+    "@types/node": "^22.0.0",
     "@types/react": "^18.3.0",
     "typescript": "^5.5.0"
   },

packages/editor/src/core/block-registry.ts

@@ -10,16 +10,16 @@
  * is server-safe.
  */
 
-import type { ComponentType } from "react";
 import type { z } from "zod";
-import type { BlockEditProps } from "@nextpress/blocks";
 import type { EditorBlockDefinition } from "./types";
 
 const editorRegistry = new Map<string, EditorBlockDefinition>();
 
 /** Register a block's edit component for the editor */
-export function registerEditorBlock(def: EditorBlockDefinition): void {
-  editorRegistry.set(def.type, def);
+export function registerEditorBlock<
+  TSchema extends z.ZodObject<z.ZodRawShape>,
+>(def: EditorBlockDefinition<TSchema>): void {
+  editorRegistry.set(def.type, def as EditorBlockDefinition);
 }
 
 /** Get the editor definition (includes edit component) */

packages/editor/src/core/editor-state.ts

@@ -74,7 +74,7 @@ export function editorReducer(
       const blockIndex = state.blocks.findIndex((b) => b.id === action.id);
       if (blockIndex === -1) return state;
       const newBlocks = [...state.blocks];
-      const [moved] = newBlocks.splice(blockIndex, 1);
+      const [moved] = newBlocks.splice(blockIndex, 1) as [BlockData];
       newBlocks.splice(action.toIndex, 0, moved);
       return pushHistory(state, {
         ...state,