Skip to content

Commit 1c608fc

Browse files
committed
Merge branch 'main' into samply-kit
2 parents a299cd3 + eedac18 commit 1c608fc

2 files changed

Lines changed: 15 additions & 3 deletions

File tree

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# IDEs
22
.vscode
33
.idea
4+
.nvim.lua
45

56
# Rust/Cargo
67
debug/
@@ -15,4 +16,4 @@ Cargo.lock
1516
**/*.rs.bk
1617

1718
# Code coverage output
18-
lcov.info
19+
lcov.info

CONTRIBUTING.md

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,23 @@
11
# Contributor's guide
22

3-
## Commit signing
3+
## Commits
4+
### Commit signing
45

56
Enable [commit signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
67

78
```sh
89
git config commit.gpgsign true
910
```
11+
12+
### Commit messages
13+
14+
Strive to write informative commit messages: a single line summary of the change and maybe a small exposition in the body of the message.
15+
If you do write an exposition, include parts of it in the PR description and in the source code as well. This gives multiple avenues to find the motivation for the change.
16+
17+
Avoid writing commit messages like "wip", "fix", or drawn-out commit messages that actually say nothing. Use fixup commits instead, as these can be automatically squashed, thereby keeping the log clean.
18+
To make a fixup commit: `git commit --fixup SHA`, where SHA points to the commit hash where, looking back, you would have liked to have made this change in the first place.
19+
When you publish the branch for review, do `git rebase --autosquash` beforehand and the history will be clean. This way you'll have chronological checkpoints while developing. Upon publishing, you'll have a clean commit history that tells a logically constructive story without odd backreferences to earlier points.
20+
Fixup commits are also useful during reviews, as they maintain the chronological points of the discussion and will be squashed out when merging.
1021

1122
## Prerequisites
1223

@@ -117,4 +128,4 @@ Many other profiling libraries exist, please check the [Rust Performance Book](h
117128
But these 3 should be enough for the average application to identify bottlenecks and optimize them.
118129

119130
For async-rust we also recommend: [Tracing](https://crates.io/crates/tracing), [Tokio-Console](https://crates.io/crates/tokio-console), and [Oha](https://crates.io/crates/oha).
120-
For Rayon-based parallel Rust code, we recommend Samply in combination with [Samply Kit](https://github.com/xrvdg/samply-kit) to filter out Rayon from the stack traces.
131+
For Rayon-based parallel Rust code, we recommend Samply in combination with [Samply Kit](https://github.com/xrvdg/samply-kit) to filter out Rayon from the stack traces.

0 commit comments

Comments
 (0)