commit tx before update the status

Signed-off-by: Hitesh Wadekar <hwadekar@nvidia.com>

Author: hwadekar-nv

api/pkg/api/handler/nvlinklogicalpartition.go

@@ -339,49 +339,52 @@ func (cibph CreateNVLinkLogicalPartitionHandler) Handle(c echo.Context) error {
 
 	logger.Info().Str("Workflow ID", wid).Msg("completed NVLink Logical Partition creation workflow")
 
+	// commit transaction - must commit once NVLink Logical Partition has been created
+	// If we have an error while updating the status, we'll rollback REST layer cache
+	// but object will remain on Site
+	err = tx.Commit()
+	if err != nil {
+		logger.Error().Err(err).Msg("error committing NVLink Logical Partition transaction to DB")
+		return cerr.NewAPIErrorResponse(c, http.StatusInternalServerError, "Failed to create NVLink Logical Partition, DB error", nil)
+	}
+
+	// set committed so, deferred cleanup functions will do nothing
+	txCommitted = true
+
 	// update the db record for NVLink Logical Partition with the status from the workflow
+	// If we run into an error, we'll log it but won't return error
 	unvllp := nvllp
+	ussd := ssd // Use original status detail by default
 	if workflowResult != nil {
 		logger.Info().Str("Workflow ID", wid).Msg("received NVLink Logical Partition info from workflow")
 
 		status, statusMessage := common.GetNVLinkLogicalPartitionStatus(workflowResult.Status.State)
 		// if status is nil, then default is pending and inventory will be updating status from workflow
 		if status != nil {
-			// update the db record for NVLink Logical Partition
-			unvllp, err = nvllpDAO.Update(ctx, tx, cdbm.NVLinkLogicalPartitionUpdateInput{
+			// update the db record for NVLink Logical Partition (using new transaction/nil since tx is committed)
+			unvllp, err = nvllpDAO.Update(ctx, nil, cdbm.NVLinkLogicalPartitionUpdateInput{
 				NVLinkLogicalPartitionID: nvllp.ID,
 				Status:                   status,
 			})
 
 			if err != nil {
-				logger.Error().Err(err).Msg("unable to update NVLink Logical Partition record in DB")
-				return cerr.NewAPIErrorResponse(c, http.StatusInternalServerError, "Failed to update NVLink Logical Partition, DB error", nil)
-			}
-
-			ssd, err := sdDAO.CreateFromParams(ctx, tx, nvllp.ID.String(), *status, statusMessage)
-			if err != nil {
-				logger.Error().Err(err).Msg("error creating Status Detail DB entry")
-				return cerr.NewAPIErrorResponse(c, http.StatusInternalServerError, "Failed to create Status Detail for NVLink Logical Partition, DB error", nil)
-			}
-			if ssd == nil {
-				logger.Error().Msg("Status Detail DB entry not returned from CreateFromParams")
-				return cerr.NewAPIErrorResponse(c, http.StatusInternalServerError, "Failed to get new Status Detail for NVLink Logical Partition, DB error", nil)
+				logger.Error().Err(err).Msg("unable to update NVLink Logical Partition record in DB, but object already exists on Site")
+				// Continue with original nvllp and ssd - don't return error
+			} else {
+				newSSD, err := sdDAO.CreateFromParams(ctx, nil, nvllp.ID.String(), *status, statusMessage)
+				if err != nil {
+					logger.Error().Err(err).Msg("error creating Status Detail DB entry, but object already exists on Site")
+					// Continue with original ssd - don't return error
+				} else if newSSD != nil {
+					// Use the new status detail if successfully created
+					ussd = newSSD
+				}
 			}
 		}
 	}
 
-	// commit transaction
-	err = tx.Commit()
-	if err != nil {
-		logger.Error().Err(err).Msg("error committing NVLink Logical Partition transaction to DB")
-		return cerr.NewAPIErrorResponse(c, http.StatusInternalServerError, "Failed to create NVLink Logical Partition, DB error", nil)
-	}
-
-	// set committed so, deferred cleanup functions will do nothing
-	txCommitted = true
-
 	// create response
-	apiNVLinkLogicalPartition := model.NewAPINVLinkLogicalPartition(unvllp, nil, nil, []cdbm.StatusDetail{*ssd})
+	apiNVLinkLogicalPartition := model.NewAPINVLinkLogicalPartition(unvllp, nil, nil, []cdbm.StatusDetail{*ussd})
 	logger.Info().Msg("finishing API handler")
 	return c.JSON(http.StatusCreated, apiNVLinkLogicalPartition)
 }