From bbae12f24835a22c33846704e83e1ccfedefac4c Mon Sep 17 00:00:00 2001 From: Kaining Zhong Date: Fri, 2 Oct 2026 20:06:30 +0000 Subject: [PATCH 1/3] [Common] Enable all activations for MXFP8 C++ Unittest Signed-off-by: Kaining Zhong --- tests/cpp/operator/test_cast_mxfp8.cu | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/cpp/operator/test_cast_mxfp8.cu b/tests/cpp/operator/test_cast_mxfp8.cu index 9368d4030b5..8677492e141 100644 --- a/tests/cpp/operator/test_cast_mxfp8.cu +++ b/tests/cpp/operator/test_cast_mxfp8.cu @@ -750,10 +750,10 @@ std::vector scaling_directions_2d_quantize = { std::vector Activation_types = { ActivationType::Identity, ActivationType::GeLU, - // ActivationType::SiLU, - // ActivationType::ReLU, - // ActivationType::QGeLU, - // ActivationType::SReLU, + ActivationType::SiLU, + ActivationType::ReLU, + ActivationType::QGeLU, + ActivationType::SReLU, }; class FusedCastMXFP8TestSuite : public ::testing::TestWithParam From 664e244e4ed9e57c1f2d8970084b62975e7f93be Mon Sep 17 00:00:00 2001 From: Kaining Zhong Date: Fri, 2 Oct 2026 21:17:35 +0000 Subject: [PATCH 2/3] nit Signed-off-by: Kaining Zhong --- tests/cpp/operator/test_cast_mxfp8.cu | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/cpp/operator/test_cast_mxfp8.cu b/tests/cpp/operator/test_cast_mxfp8.cu index 8677492e141..16fb977b788 100644 --- a/tests/cpp/operator/test_cast_mxfp8.cu +++ b/tests/cpp/operator/test_cast_mxfp8.cu @@ -746,7 +746,6 @@ std::vector scaling_directions_2d_quantize = { MXFP82DScalingDirection::Bidirectional, }; -// Only GeLU activation tests are supported std::vector Activation_types = { ActivationType::Identity, ActivationType::GeLU, From 0d2b69a480749adf49346af9524e5283ee82fd2c Mon Sep 17 00:00:00 2001 From: Kaining Zhong Date: Fri, 2 Oct 2026 23:31:37 +0000 Subject: [PATCH 3/3] also enable other activations for grouped MXFP8 Signed-off-by: Kaining Zhong --- tests/cpp/operator/test_cast_mxfp8_grouped.cu | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/cpp/operator/test_cast_mxfp8_grouped.cu b/tests/cpp/operator/test_cast_mxfp8_grouped.cu index c2309f7aa4b..03ec1acd001 100644 --- a/tests/cpp/operator/test_cast_mxfp8_grouped.cu +++ b/tests/cpp/operator/test_cast_mxfp8_grouped.cu @@ -657,10 +657,10 @@ std::vector processing_methods = { std::vector activation_kinds = { ActivationKind::Identity, ActivationKind::GeLU, - // ActivationKind::SiLU, - // ActivationKind::ReLU, - // ActivationKind::QGeLU, - // ActivationKind::SReLU, + ActivationKind::SiLU, + ActivationKind::ReLU, + ActivationKind::QGeLU, + ActivationKind::SReLU, }; enum ScalingDirection { @@ -1012,7 +1012,7 @@ INSTANTIATE_TEST_SUITE_P( GroupedFusedCastMXFP8TestSuite, ::testing::Combine( ::testing::Values(ProcessingMethod::CAST_DBIAS_DACT), - ::testing::Values(ActivationKind::GeLU), + ::testing::ValuesIn(activation_kinds), ::testing::ValuesIn(scaling_directions), ::testing::ValuesIn(input_config_same_both_multichunk), ::testing::Values(DType::kBFloat16),