diff --git a/src/cleanup_swiftnet.c b/src/cleanup_swiftnet.c index 0bdb220..4bc8752 100644 --- a/src/cleanup_swiftnet.c +++ b/src/cleanup_swiftnet.c @@ -5,7 +5,7 @@ #include #include -static inline void close_listeners() { +static inline void close_listeners(void) { LOCK_ATOMIC_DATA_TYPE(&listeners.atomic_lock); LOOP_HASHMAP(&listeners, struct Listener*, @@ -22,13 +22,13 @@ static inline void close_listeners() { hashmap_destroy(&listeners); } -static inline void close_background_service() { +static inline void close_background_service(void) { atomic_store_explicit(&swiftnet_closing, true, memory_order_release); pthread_join(memory_cleanup_thread, NULL); } -void swiftnet_cleanup() { +void swiftnet_cleanup(void) { close_background_service(); allocator_destroy(&packet_queue_node_memory_allocator ENABLE_INTERNAL_CHECK); diff --git a/src/initialize_swiftnet.c b/src/initialize_swiftnet.c index 920b10d..b190428 100644 --- a/src/initialize_swiftnet.c +++ b/src/initialize_swiftnet.c @@ -55,7 +55,7 @@ pthread_t memory_cleanup_thread; _Atomic bool swiftnet_closing; -static inline void initialize_allocators() { +static inline void initialize_allocators(void) { packet_queue_node_memory_allocator = allocator_create(sizeof(struct SwiftNetPacketQueueNode), 40 * SWIFT_NET_MEMORY_USAGE); packet_callback_queue_node_memory_allocator = allocator_create(sizeof(struct SwiftNetPacketCallbackQueueNode), 40 * SWIFT_NET_MEMORY_USAGE); server_packet_data_memory_allocator = allocator_create(sizeof(struct SwiftNetServerPacketData), 40 * SWIFT_NET_MEMORY_USAGE); @@ -79,7 +79,7 @@ static inline void initialize_allocators() { #endif } -static inline void initialize_vectors() { +static inline void initialize_vectors(void) { #ifndef SWIFT_NET_DISABLE_REQUESTS requests_sent = hashmap_create(&request_sent_key_allocator); #endif @@ -87,11 +87,11 @@ static inline void initialize_vectors() { listeners = hashmap_create(NULL); } -static inline void initialize_memory_cleanup_thread() { +static inline void initialize_memory_cleanup_thread(void) { pthread_create(&memory_cleanup_thread, NULL, memory_cleanup_background_service, NULL); } -void swiftnet_initialize() { +void swiftnet_initialize(void) { #ifdef SWIFT_NET_BACKEND_DPDK char dpdk_args[1024]; char* argv[32]; diff --git a/src/swift_net.h b/src/swift_net.h index 1570bef..4f18934 100644 --- a/src/swift_net.h +++ b/src/swift_net.h @@ -374,7 +374,7 @@ extern void swiftnet_client_cleanup(struct SwiftNetClientConnection* const clien extern void swiftnet_server_cleanup(struct SwiftNetServer* const server); // Initialize the SwiftNet library. -extern void swiftnet_initialize(); +extern void swiftnet_initialize(void); // Send a packet from the client to its connected server. extern void swiftnet_client_send_packet( @@ -445,7 +445,7 @@ extern void swiftnet_server_destroy_packet_data( ); // Clean up the entire SwiftNet library. -extern void swiftnet_cleanup(); +extern void swiftnet_cleanup(void); #ifndef SWIFT_NET_DISABLE_REQUESTS diff --git a/tests/integration_tests_dpdk/src/making_request.c b/tests/integration_tests_dpdk/src/making_request.c index 87c50c6..bd5498c 100644 --- a/tests/integration_tests_dpdk/src/making_request.c +++ b/tests/integration_tests_dpdk/src/making_request.c @@ -22,13 +22,13 @@ static _Atomic uint32_t g_response_data_len = 0; const uint8_t g_make_request_code = 0xFF; -static void wait_until_response_sent() { +static void wait_until_response_sent(void) { while (atomic_load_explicit(&g_sent_response, memory_order_acquire) == false) { usleep(1000); } } -static void reset_test_state() { +static void reset_test_state(void) { swiftnet_server_cleanup(atomic_load_explicit(&g_server, memory_order_acquire)); swiftnet_client_cleanup(atomic_load_explicit(&g_client_conn, memory_order_acquire)); diff --git a/tests/integration_tests_dpdk/src/run_tests.c b/tests/integration_tests_dpdk/src/run_tests.c index 7aaca26..0f201cd 100644 --- a/tests/integration_tests_dpdk/src/run_tests.c +++ b/tests/integration_tests_dpdk/src/run_tests.c @@ -15,7 +15,7 @@ char private_ip_address_testing[INET_ADDRSTRLEN]; -int main() { +int main(void) { get_private_ip_from_socket(); const struct Test tests[] = { diff --git a/tests/integration_tests_dpdk/src/sending_packet.c b/tests/integration_tests_dpdk/src/sending_packet.c index 455cd1c..182e6a9 100644 --- a/tests/integration_tests_dpdk/src/sending_packet.c +++ b/tests/integration_tests_dpdk/src/sending_packet.c @@ -20,7 +20,7 @@ static _Atomic (uint8_t*) g_server_data = NULL; static _Atomic uint32_t g_client_data_len = 0; static _Atomic uint32_t g_server_data_len = 0; -static void reset_test_state() { +static void reset_test_state(void) { swiftnet_server_cleanup(atomic_load_explicit(&g_server, memory_order_acquire)); swiftnet_client_cleanup(atomic_load_explicit(&g_client_conn, memory_order_acquire)); diff --git a/tests/integration_tests_pcap/src/making_request.c b/tests/integration_tests_pcap/src/making_request.c index d2382f7..b56bb6e 100644 --- a/tests/integration_tests_pcap/src/making_request.c +++ b/tests/integration_tests_pcap/src/making_request.c @@ -22,13 +22,13 @@ static _Atomic uint32_t g_response_data_len = 0; const uint8_t g_make_request_code = 0xFF; -static void wait_until_response_sent() { +static void wait_until_response_sent(void) { while (atomic_load_explicit(&g_sent_response, memory_order_acquire) == false) { usleep(1000); } } -static void reset_test_state() { +static void reset_test_state(void) { swiftnet_server_cleanup(atomic_load_explicit(&g_server, memory_order_acquire)); swiftnet_client_cleanup(atomic_load_explicit(&g_client_conn, memory_order_acquire)); diff --git a/tests/integration_tests_pcap/src/run_tests.c b/tests/integration_tests_pcap/src/run_tests.c index b1f04bf..872f549 100644 --- a/tests/integration_tests_pcap/src/run_tests.c +++ b/tests/integration_tests_pcap/src/run_tests.c @@ -15,7 +15,7 @@ char private_ip_address_testing[INET_ADDRSTRLEN]; -int main() { +int main(void) { get_private_ip_from_socket(); const struct Test tests[] = { diff --git a/tests/integration_tests_pcap/src/sending_packet.c b/tests/integration_tests_pcap/src/sending_packet.c index 27ddcd9..0d89937 100644 --- a/tests/integration_tests_pcap/src/sending_packet.c +++ b/tests/integration_tests_pcap/src/sending_packet.c @@ -20,7 +20,7 @@ static _Atomic (uint8_t*) g_server_data = NULL; static _Atomic uint32_t g_client_data_len = 0; static _Atomic uint32_t g_server_data_len = 0; -static void reset_test_state() { +static void reset_test_state(void) { swiftnet_server_cleanup(atomic_load_explicit(&g_server, memory_order_acquire)); swiftnet_client_cleanup(atomic_load_explicit(&g_client_conn, memory_order_acquire)); diff --git a/tests/performance_tests/src/main.c b/tests/performance_tests/src/main.c index c56dbd7..d58a0ff 100644 --- a/tests/performance_tests/src/main.c +++ b/tests/performance_tests/src/main.c @@ -81,7 +81,7 @@ void send_large_packets(const bool loopback) { swiftnet_client_cleanup(client); } -int main() { +int main(void) { swiftnet_initialize(); send_large_packets(true); diff --git a/tests/shared.h b/tests/shared.h index bb34e97..c24ee1e 100644 --- a/tests/shared.h +++ b/tests/shared.h @@ -29,7 +29,7 @@ enum ConnectionType { extern char private_ip_address_testing[INET_ADDRSTRLEN]; -static inline int get_private_ip_from_socket() { +static inline int get_private_ip_from_socket(void) { const int temp_socket = socket(AF_INET, SOCK_DGRAM, 0); if (temp_socket < 0) { PRINT_ERROR("Failed to create temp socket");