feat(favorites): Fix Loading Issues and Add New Display View by mattsigal · Pull Request #414 · Moonfin-Client/Moonfin-Core

mattsigal · 2026-06-07T20:29:40Z

feat(favorites): Fix Loading Issues and Add New Display View

Summary

This PR implements several enhancements to the Favorites screen, introducing dynamic view style switching (Home/Rows vs Library/Grid views), restoring key focus feedback, implementing smooth row-to-row vertical jumping, and extending lazy loading support.

Related Issues

Link related issues or tickets separated by commas.

Closes #
Fixes Issues while on favorites #392
Related to #

Type of Change

Changes Made

Added a setting under the cog settings dialog on the Favorites page that allows users to toggle the view between Home View (categorized rows; default) and Library View (flat grid of all favorites). The preference is persisted in user preferences.
Removed the logic that suppressed the focus indicator borders on MediaCards, restoring visible border feedback (essential for TV/D-pad navigation layouts like Neon Pulse).
Updated LockedFocusRow key event handling to bubble unhandled vertical D-pad navigation key events (up/down) up to the system rather than trapping them. Implemented custom row-to-row jump tracking (onVerticalNavigation) in the Favorites home view to shift focus and center the viewport on the active row using Scrollable.ensureVisible. Focus bubbles back up to header buttons (Home, Sort, Settings cog) naturally when navigating UP from the top row.
Added lazy loading/pagination support to both views (categorized rows and flat grid) to lazy load media items when scrolling near limits to fix the original issue reported (got there in the end).

Files Changed

lib/preference/preference_constants.dart: Introduced FavoritesViewStyle enum (home and library).
lib/preference/user_preferences.dart: Registered the favoritesViewStyle user preference.
lib/data/viewmodels/favorites_view_model.dart: Implemented fetching pagination offsets for flat grid paging (loadMoreGrid) and row category paging (loadMoreForType).
lib/ui/widgets/focus/locked_focus_row.dart: Updated isUpKey and isDownKey event logic to respect the vertical navigation handler's return state and bubble unhandled key presses.
lib/ui/screens/browse/favorites_screen.dart: _buildGrid(), _onRowVerticalNavigation, and added view switching UI selection tiles inside Display Settings.

Platform

Testing

Describe how this change was tested.

Tested on emulator / simulator
Tested on physical device
Manual testing completed
Not tested (explain why):

Test Steps

Navigate to the Favorites screen.
Verify that focused items correctly draw the focus border indicators.
Open display settings (cog icon) and switch view to Library View. Confirm the layout displays as a grid and that scrolling to the bottom lazy-loads additional cards.
Switch view back to Home View. Use the D-pad to navigate left/right within a row and verify that focus does not escape the row edges horizontally.
Press D-pad Down or Up to navigate between Movie and TV Show rows; verify that focus transitions smoothly and centers the active row in the viewport.
From the top row, press D-pad Up to confirm focus exits the row and targets the toolbar header actions (Home/Sort/Settings).

Screenshots (if applicable)

OLD LIBRARY VIEW

NEW LIBRARY VIEW

Checklist

Code builds successfully
Code follows project style and conventions
No unnecessary commented-out code
No new warnings introduced

RadicalMuffinMan · 2026-06-07T22:43:13Z

@@ -220,72 +325,125 @@ class _FavoritesScreenState extends State<FavoritesScreen> {
    final isNeon = ThemeRegistry.active.id == ThemeRegistry.neonPulseId;


Suggested change

final isNeon = ThemeRegistry.active.id == ThemeRegistry.neonPulseId;

supressFocusGlow from 317 already covers this and this isnt needed

RadicalMuffinMan · 2026-06-07T22:43:48Z

+                  final focusColor = Color(
+                    _prefs.get(UserPreferences.focusColor).colorValue,
+                  );
+                  final isNeon = ThemeRegistry.active.id == ThemeRegistry.neonPulseId;


Suggested change

final isNeon = ThemeRegistry.active.id == ThemeRegistry.neonPulseId;

same thing

RadicalMuffinMan · 2026-06-07T22:49:16Z

+            : 1.0;
+        final textHeight = (hasSubtitles ? 42.0 : 24.0) * desktopTextScale;
+        final childAspectRatio = cellWidth / (cellWidth / ar + textHeight);
+


Suggested change

final focusColor = Color(_prefs.get(UserPreferences.focusColor).colorValue);

final focusExpansion = _prefs.get(UserPreferences.cardFocusExpansion);

final suppressFocusGlow = ThemeRegistry.active.borders.focusGlow.isNotEmpty;

instead of redrawing for every card just make it a constant so its computed once not per cell

RadicalMuffinMan · 2026-06-07T22:49:45Z

+                delegate: SliverChildBuilderDelegate((context, index) {
+                  final item = _vm.gridItems[index];
+                  final itemAspectRatio = _itemAspectRatio(item);
+                  final focusColor = Color(


Suggested change

final focusColor = Color(

RadicalMuffinMan · 2026-06-07T22:49:53Z

+                  final item = _vm.gridItems[index];
+                  final itemAspectRatio = _itemAspectRatio(item);
+                  final focusColor = Color(
+                    _prefs.get(UserPreferences.focusColor).colorValue,


Suggested change

_prefs.get(UserPreferences.focusColor).colorValue,

RadicalMuffinMan · 2026-06-07T22:50:00Z

+                  final itemAspectRatio = _itemAspectRatio(item);
+                  final focusColor = Color(
+                    _prefs.get(UserPreferences.focusColor).colorValue,
+                  );


Suggested change

);

RadicalMuffinMan · 2026-06-07T22:50:07Z

+                    _prefs.get(UserPreferences.focusColor).colorValue,
+                  );
+                  final isNeon = ThemeRegistry.active.id == ThemeRegistry.neonPulseId;
+                  final focusExpansion = _prefs.get(UserPreferences.cardFocusExpansion);


Suggested change

final focusExpansion = _prefs.get(UserPreferences.cardFocusExpansion);

RadicalMuffinMan · 2026-06-07T22:50:14Z

+                  );
+                  final isNeon = ThemeRegistry.active.id == ThemeRegistry.neonPulseId;
+                  final focusExpansion = _prefs.get(UserPreferences.cardFocusExpansion);
+                  final suppressFocusGlow = ThemeRegistry.active.borders.focusGlow.isNotEmpty;


Suggested change

final suppressFocusGlow = ThemeRegistry.active.borders.focusGlow.isNotEmpty;

mattsigal · 2026-06-07T23:06:22Z

All changes done!

…cking - Restored focus indicator border on MediaCards on Favorites screen. - Introduced FavoritesViewStyle enum (home/library) in preferences. - Added 'Switch View' setting to toggled display settings dialog on the Favorites screen. - Implemented flat grid view layout builder with scroll-to-bottom lazy-loading and focus node mixin. - Upgraded LockedFocusRow key event handling to propagate unhandled vertical focus events instead of swallowing them. - Implemented onVerticalNavigation row key tracking and viewport centering (via Scrollable.ensureVisible) to easily jump between Movie, TV Show, and other category rows on TV/desktop.

github-actions Bot added Android iOS Linux macOS Windows labels Jun 7, 2026

RadicalMuffinMan requested changes Jun 7, 2026

View reviewed changes

mattsigal force-pushed the feature/favorites-update branch from b611adf to 2f62849 Compare June 7, 2026 23:06

mattsigal force-pushed the feature/favorites-update branch from 2f62849 to df4df20 Compare June 7, 2026 23:07

RadicalMuffinMan merged commit 14b3de9 into Moonfin-Client:main Jun 7, 2026
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(favorites): Fix Loading Issues and Add New Display View#414

feat(favorites): Fix Loading Issues and Add New Display View#414
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
mattsigal:feature/favorites-update

mattsigal commented Jun 7, 2026 •

edited

Loading

Uh oh!

RadicalMuffinMan Jun 7, 2026

Uh oh!

RadicalMuffinMan Jun 7, 2026

Uh oh!

RadicalMuffinMan Jun 7, 2026

Uh oh!

RadicalMuffinMan Jun 7, 2026

Uh oh!

RadicalMuffinMan Jun 7, 2026

Uh oh!

RadicalMuffinMan Jun 7, 2026

Uh oh!

RadicalMuffinMan Jun 7, 2026

Uh oh!

RadicalMuffinMan Jun 7, 2026

Uh oh!

mattsigal commented Jun 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -220,72 +325,125 @@ class _FavoritesScreenState extends State<FavoritesScreen> {
		final isNeon = ThemeRegistry.active.id == ThemeRegistry.neonPulseId;

Conversation

mattsigal commented Jun 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

feat(favorites): Fix Loading Issues and Add New Display View

Summary

Related Issues

Type of Change

Changes Made

Files Changed

Platform

Testing

Test Steps

Screenshots (if applicable)

OLD LIBRARY VIEW

NEW LIBRARY VIEW

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mattsigal commented Jun 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mattsigal commented Jun 7, 2026 •

edited

Loading