Fix downloads not counted due to Laravel's dumb way of handling relations

Essentially it DID NOT wrap the relations conditions which meant that single orWhere check made sure to make the relation useless and return true as long as you have a single download on said IP

Author: Luffyyy

backend/app/Http/Controllers/FileController.php

@@ -376,7 +376,7 @@ public function getVersions(Request $request) {
      */
     public function registerDownload(Request $request, File $file)
     {
-        ModService::registerDownload($file);
+        return ModService::registerDownload($file);
     }
 
     /**

backend/app/Services/ModService.php

@@ -396,12 +396,13 @@ public static function registerDownload(File|Link $downloadable)
          * @var Builder
          */
         $downloads = $downloadable->downloadsRelation();
-        $alreadyDownloadedFile = $downloads->when(isset($user), fn($q) => $q->where('user_id', $user->id))
-            ->orWhere('ip_address', $ip)
-            ->exists();
+        $alreadyDownloadedFile = $downloads->where(function($q) use ($user, $ip) {
+            $q->when(isset($user), fn($q) => $q->where('user_id', $user->id))
+                ->orWhere('ip_address', $ip);
+        })->exists();
 
         if ($alreadyDownloadedFile) {
-            return response()->noContent(201);
+            return response()->noContent(200);
         }
 
         // Create download for file or link
@@ -420,7 +421,7 @@ public static function registerDownload(File|Link $downloadable)
         })->where('mod_id', $mod->id)->exists();
 
         if ($alreadyDownloadedMod) {
-            return response()->noContent(201);
+            return response()->noContent(200);
         }
 
         $download = new ModDownload([