Skip to content

feat: add .dockerignore#423

Merged
e06084 merged 1 commit into
MigoXLab:devfrom
e06084:dev
Jun 8, 2026
Merged

feat: add .dockerignore#423
e06084 merged 1 commit into
MigoXLab:devfrom
e06084:dev

Conversation

@e06084

@e06084 e06084 commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a .dockerignore file to exclude development, build, and environment files from the Docker build context. The reviewer suggested simplifying the configuration by using **/ wildcards to eliminate duplicate patterns for the root and nested dingo/ directories.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread .dockerignore
Comment on lines +1 to +40
.git
.DS_Store

__pycache__/
**/__pycache__/
.pytest_cache/
.mypy_cache/
.ruff_cache/
.coverage
htmlcov/

.venv/
venv/
env/
*.egg-info/
build/
dist/

outputs/
output/
*.log

# Also match when this repository is nested under a parent Docker context.
dingo/.git
dingo/.DS_Store
dingo/**/__pycache__/
dingo/.pytest_cache/
dingo/.mypy_cache/
dingo/.ruff_cache/
dingo/.coverage
dingo/htmlcov/
dingo/.venv/
dingo/venv/
dingo/env/
dingo/*.egg-info/
dingo/build/
dingo/dist/
dingo/outputs/
dingo/output/
dingo/*.log

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The .dockerignore file contains duplicated patterns for the root directory and the nested dingo/ directory. We can simplify this and improve maintainability by using **/ wildcards, which match directories at any level (including the root). This avoids having to maintain two parallel lists of ignored patterns.

**/.git
**/.DS_Store

**/__pycache__/
**/.pytest_cache/
**/.mypy_cache/
**/.ruff_cache/
**/.coverage
**/htmlcov/

**/.venv/
**/venv/
**/env/
**/*.egg-info/
**/build/
**/dist/

**/outputs/
**/output/
**/*.log

@e06084 e06084 merged commit 1654962 into MigoXLab:dev Jun 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant