fix addskill input handling

Fixes #12

Author: MhankBarBar

docs/commands/owner.md

@@ -199,14 +199,15 @@ List all dynamically created commands.
 Add an AI skill — custom instructions that the AI follows.
 
 ```
-/addskill <name>
-<instructions>
+/addskill <name> <instructions>
+/addskill <url>
+/addskill            # with attached .md file
+/addskill <name>     # when replying to text
 ```
 
 **Example:**
 ```
-/addskill translator
-Always translate messages to English when asked.
+/addskill translator Always translate messages to English when asked.
 ```
 
 ## /delskill

docs/features/ai.md

@@ -80,17 +80,31 @@ Skills are custom instructions that the AI follows. They let you customize the A
 ### Adding a Skill
 
 ```
-/addskill <name>
-<instructions>
+/addskill <name> <instructions>
 ```
 
 **Example:**
 
 ```
-/addskill translator
-When someone asks you to translate, translate the text
-to the requested language. If no language is specified,
-translate to English.
+/addskill translator When someone asks you to translate, translate to requested language.
+```
+
+Alternative methods:
+
+```
+/addskill <url-to-markdown-skill>
+```
+
+or attach a `.md` skill file and send:
+
+```
+/addskill
+```
+
+You can also reply to a text message and send:
+
+```
+/addskill <name>
 ```
 
 ### Managing Skills

src/commands/owner/addskill.py

@@ -2,15 +2,53 @@
 Add skill command - Add AI skills from URL or file.
 """
 
+from __future__ import annotations
+
+from typing import Any
+
 from core import symbols as sym
 from core.command import Command, CommandContext
 
 
+def build_inline_skill(raw_args: str, quoted_text: str = "") -> dict[str, Any] | None:
+    """Build inline skill payload from command args/quoted text.
+
+    Supports:
+    - addskill <name> <instructions>
+    - addskill <name>   (with quoted message text as instructions)
+    """
+    raw = (raw_args or "").strip()
+    if not raw:
+        return None
+
+    parts = raw.split(maxsplit=1)
+    if not parts:
+        return None
+
+    name = parts[0].strip().lower()
+    if not name:
+        return None
+
+    content = parts[1].strip() if len(parts) > 1 else ""
+    if not content:
+        content = (quoted_text or "").strip()
+    if not content:
+        return None
+
+    return {
+        "name": name,
+        "description": f"Inline skill: {name}",
+        "trigger": "always",
+        "priority": 10,
+        "content": content,
+    }
+
+
 class AddSkillCommand(Command):
     name = "addskill"
     aliases = ["skill"]
-    description = "Add an AI skill from URL or attached file"
-    usage = "addskill <url> or attach .md file"
+    description = "Add an AI skill from inline text, URL, or attached file"
+    usage = "addskill <name> <instructions> | addskill <url> | attach .md file"
     category = "owner"
     owner_only = True
 
@@ -24,9 +62,9 @@ async def execute(self, ctx: CommandContext) -> None:
         )
 
         if ctx.args:
-            url = ctx.args[0]
-            if url.startswith("http://") or url.startswith("https://"):
-                skill = await load_skill_from_url(url)
+            first_arg = ctx.args[0]
+            if first_arg.startswith("http://") or first_arg.startswith("https://"):
+                skill = await load_skill_from_url(first_arg)
                 if skill:
                     save_skill_to_file(skill)
                     agentic_ai.add_skill(
@@ -83,10 +121,34 @@ async def execute(self, ctx: CommandContext) -> None:
                 )
                 return
 
+        quoted_text = ""
+        if ctx.message.quoted_message and ctx.message.quoted_message.get("text"):
+            quoted_text = str(ctx.message.quoted_message.get("text") or "")
+
+        inline_skill = build_inline_skill(ctx.raw_args, quoted_text)
+        if inline_skill:
+            save_skill_to_file(inline_skill)
+            agentic_ai.add_skill(
+                inline_skill["name"],
+                inline_skill["content"],
+                inline_skill["description"],
+                inline_skill["trigger"],
+            )
+            await ctx.client.reply(
+                ctx.message,
+                f"{sym.SUCCESS} *Skill Added*\n\n"
+                f"*Name:* `{inline_skill['name']}`\n"
+                f"*Description:* {inline_skill['description']}\n"
+                f"*Trigger:* {inline_skill['trigger']}",
+            )
+            return
+
         await ctx.client.reply(
             ctx.message,
             f"{sym.INFO} *Add AI Skill*\n\n"
             f"Usage:\n"
+            f"• `/addskill <name> <instructions>` - Inline skill\n"
+            f"• Reply to text with `/addskill <name>`\n"
             f"• `/addskill <url>` - Load from URL\n"
             f"• Attach a `.md` file and send `/addskill`\n\n"
             f"*Skill Format:*\n"

src/core/constants.py

@@ -43,6 +43,7 @@
     ("extendedTextMessage", "text"),
     ("imageMessage", "caption"),
     ("videoMessage", "caption"),
+    ("documentMessage", "caption"),
 )
 
 PHOTO_IMAGE_EXTENSIONS = frozenset(

tests/test_addskill.py

@@ -0,0 +1,20 @@
+from commands.owner.addskill import build_inline_skill
+
+
+def test_build_inline_skill_from_inline_text():
+    skill = build_inline_skill("translator Always translate to English")
+    assert skill is not None
+    assert skill["name"] == "translator"
+    assert "Always translate" in skill["content"]
+    assert skill["trigger"] == "always"
+
+
+def test_build_inline_skill_from_quoted_text():
+    skill = build_inline_skill("translator", quoted_text="Translate to Indonesian")
+    assert skill is not None
+    assert skill["name"] == "translator"
+    assert skill["content"] == "Translate to Indonesian"
+
+
+def test_build_inline_skill_requires_content():
+    assert build_inline_skill("translator") is None

tests/test_message_constants.py

@@ -0,0 +1,5 @@
+from core.constants import TEXT_SOURCES
+
+
+def test_document_caption_is_in_text_sources():
+    assert ("documentMessage", "caption") in TEXT_SOURCES

tests/test_privacy_controls.py

@@ -60,7 +60,6 @@ def test_clear_memory_for_uncached_chat(tmp_path, monkeypatch):
     mem.add(role="user", content="hello")
     assert len(mem.get_history()) == 1
 
-    # Simulate uncached chat memory object
     memory_module._memory_cache.pop(chat, None)
 
     clear_memory(chat)