feat: add native verify command via Jolt verifier FFI#83
Merged
Conversation
linkSystemLibraryOptions has no `preferred` field in Zig 0.15.2; the correct field is `preferred_link_mode`. Without this fix, `zig build` errors before reaching the link step. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
Closes #82 |
CI failed on `zig build test` because the cargo step that produces libjolt_verifier.a was only wired as a dependency of `exe.step` — not `exe_unit_tests.step`. When only the test step runs, the staticlib is never built and the link fails with "unable to find static system library 'jolt_verifier'". Lift the cargo build step to function scope and factor the link wiring into a small local helper so both the exe and exe unit tests pull in the staticlib and depend on the cargo step. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
On Linux, Rust's std references _Unwind_* symbols (rust_eh_personality, _Unwind_RaiseException, etc.) provided by libgcc_s. Without linking it, `zig build` on Linux fails with a dozen "undefined symbol: _Unwind_*" errors when pulling in libjolt_verifier.a. Also add libdl and librt explicitly — Rust's std typically pulls these in via crt startup, but being explicit avoids surprises if the linker decides -lc alone isn't sufficient. macOS is unaffected: unwind and system libs are resolved via the SDK. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.