Skip to content

Commit 331d447

Browse files
committed
The following Design Token changes need to be made, these arose from the Design QA of the first batch of web components.
making the token value of color.border.disabled to use the same value as color.background.disabled for the Mastercard theme in both modes. Update the border radius of the checkbox to 4px in the Mastercard theme (currently set to 2px, this doesn’t really fit with the look and feel of the rest of our components) Update the border radius of the Modal to 20px in the Mastercard theme (currently set to 10px, this doesn’t really fit with the look and feel of the rest of our components such as Card and Menu) The feedback from Andy is that our Modal overlay offers too little contrast between the actual modal and the application visuals underneath. I tested in design and I agree. Therefore we need to update 2 tokens: {color.background.backdrop-mode-dark} to color.black at 60% opacity in Dark mode for the Mastercard theme. While this improves it, the modal could still use a border in order to ensure its can be distinguished form the background component.modal.border-color should reference color.border.default in both modes for the Mastercard theme.
1 parent ee20cfd commit 331d447

1 file changed

Lines changed: 12 additions & 10 deletions

File tree

plugins/made-tokens/json/made-unify-tokens.json

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6184,13 +6184,13 @@
61846184
"studio.tokens": {
61856185
"modify": {
61866186
"type": "alpha",
6187-
"value": "0.4",
6187+
"value": "0.6",
61886188
"space": "lch"
61896189
}
61906190
}
61916191
},
61926192
"$type": "color",
6193-
"$value": "{color.gray.1800}"
6193+
"$value": "{color.black}"
61946194
},
61956195
"surface": {
61966196
"default-mode-light": {
@@ -6696,11 +6696,13 @@
66966696
},
66976697
"disabled-mode-light": {
66986698
"$type": "color",
6699-
"$value": "{color.gray.100}"
6699+
"$value": "{color.gray.300}",
6700+
"$description": "Border color for elements in their disabled state"
67006701
},
67016702
"disabled-mode-dark": {
67026703
"$type": "color",
6703-
"$value": "{color.gray.1600}"
6704+
"$value": "{color.gray.1400}",
6705+
"$description": "Border color for elements in their disabled state"
67046706
},
67056707
"input-mode-light": {
67066708
"$type": "color",
@@ -7461,12 +7463,12 @@
74617463
"border-color-mode-light": {
74627464
"$componentLevelToken": "true",
74637465
"$type": "color",
7464-
"$value": "{color.border.none}"
7466+
"$value": "{color.border.default-mode-light}"
74657467
},
74667468
"border-color-mode-dark": {
74677469
"$componentLevelToken": "true",
74687470
"$type": "color",
7469-
"$value": "{color.border.none}"
7471+
"$value": "{color.border.default-mode-dark}"
74707472
},
74717473
"top-bar": {
74727474
"padding-top": {
@@ -7493,7 +7495,7 @@
74937495
"border-radius": {
74947496
"$componentLevelToken": "true",
74957497
"$type": "borderRadius",
7496-
"$value": "{border.radius.default}"
7498+
"$value": "{border.radius.large}"
74977499
},
74987500
"box-shadow": {
74997501
"$componentLevelToken": "true",
@@ -9106,7 +9108,7 @@
91069108
"border-radius": {
91079109
"$componentLevelToken": "true",
91089110
"$type": "borderRadius",
9109-
"$value": "{border-radius.01}"
9111+
"$value": "{border-radius.02}"
91109112
},
91119113
"box-shadow": {
91129114
"$componentLevelToken": "true",
@@ -14763,7 +14765,7 @@
1476314765
"border-color": {
1476414766
"$colorSchemeToken": "true",
1476514767
"$type": "color",
14766-
"$value": "{color.border.none}"
14768+
"$value": "{component.modal.border-color-mode-light}"
1476714769
}
1476814770
},
1476914771
"card": {
@@ -15967,7 +15969,7 @@
1596715969
"border-color": {
1596815970
"$colorSchemeToken": "true",
1596915971
"$type": "color",
15970-
"$value": "{color.border.none}"
15972+
"$value": "{component.modal.border-color-mode-dark}"
1597115973
}
1597215974
},
1597315975
"card": {

0 commit comments

Comments
 (0)