feat(gui): prefix undo stack entries with device name

When a firewall/cluster/host is affected, undo stack descriptions now
start with the device name (e.g. "fw1: Move Interface eth0") for
consistent, scannable undo history. Adds a prefix parameter to
move_object, set_object_folder and make_subinterface.

Author: markuslf

src/firewallfabrik/gui/object_tree.py

@@ -1060,12 +1060,18 @@ def _on_items_dropped(self, dest_item, entries):
 
         any_changed = False
         last_id = None
+        dest_prefix = self._get_device_prefix(dest_item)
         for entry in entries:
             model_cls = MODEL_MAP.get(entry.get('type'))
             if model_cls is None:
                 continue
             obj_id = uuid.UUID(entry['id'])
-            if self._ops.set_object_folder(obj_id, model_cls, target_folder):
+            if self._ops.set_object_folder(
+                obj_id,
+                model_cls,
+                target_folder,
+                prefix=dest_prefix,
+            ):
                 any_changed = True
                 last_id = obj_id
 
@@ -1308,7 +1314,12 @@ def _ctx_make_subinterface(self, item, target_iface_id):
         obj_id = item.data(0, Qt.ItemDataRole.UserRole)
         if not obj_id:
             return
-        if self._ops.make_subinterface(uuid.UUID(obj_id), uuid.UUID(target_iface_id)):
+        prefix = self._get_device_prefix(item)
+        if self._ops.make_subinterface(
+            uuid.UUID(obj_id),
+            uuid.UUID(target_iface_id),
+            prefix=prefix,
+        ):
             self.tree_changed.emit('', '')
 
     # -- Duplicate --
@@ -1420,7 +1431,13 @@ def _ctx_move(self, item, target_lib_id):
         model_cls = MODEL_MAP.get(obj_type)
         if model_cls is None:
             return
-        if self._ops.move_object(uuid.UUID(obj_id), model_cls, target_lib_id):
+        prefix = self._get_device_prefix(item)
+        if self._ops.move_object(
+            uuid.UUID(obj_id),
+            model_cls,
+            target_lib_id,
+            prefix=prefix,
+        ):
             self.tree_changed.emit(obj_id, obj_type)
             QTimer.singleShot(0, lambda: self.select_object(uuid.UUID(obj_id)))
 
@@ -1514,6 +1531,7 @@ def _ctx_paste(self, item):
                     model_cls,
                     target_lib_id,
                     folder=target_folder,
+                    prefix=prefix,
                     target_group_id=target_group_id,
                 ):
                     last_id = cb_id

src/firewallfabrik/gui/object_tree_ops.py

@@ -498,6 +498,7 @@ def move_object(
         target_lib_id,
         *,
         folder=None,
+        prefix='',
         target_group_id=None,
     ):
         """Move *obj_id* to *target_lib_id*. Returns True on success.
@@ -548,7 +549,7 @@ def move_object(
                     iface.library_id = target_lib_id
 
             session.commit()
-            self._db_manager.save_state(f'Move {obj_type} {obj_name}')
+            self._db_manager.save_state(f'{prefix}Move {obj_type} {obj_name}')
         except Exception:
             session.rollback()
             raise
@@ -769,7 +770,7 @@ def create_host_with_interfaces(
     # Folder move (drag & drop / cut-paste)
     # ------------------------------------------------------------------
 
-    def set_object_folder(self, obj_id, model_cls, folder):
+    def set_object_folder(self, obj_id, model_cls, folder, *, prefix=''):
         """Set or clear ``data.folder`` on an existing object.
 
         *folder* is the target subfolder path (e.g. ``'A/B'``) or an
@@ -796,7 +797,8 @@ def set_object_folder(self, obj_id, model_cls, folder):
             obj.data = data
             session.commit()
             self._db_manager.save_state(
-                f'Move {getattr(obj, "type", type(obj).__name__)} {obj.name} to folder'
+                f'{prefix}Move {getattr(obj, "type", type(obj).__name__)}'
+                f' {obj.name} to folder'
             )
         except Exception:
             session.rollback()
@@ -1113,7 +1115,7 @@ def remove_keyword(self, obj_ids_with_types, keyword):
     # Make subinterface
     # ------------------------------------------------------------------
 
-    def make_subinterface(self, iface_id, target_parent_iface_id):
+    def make_subinterface(self, iface_id, target_parent_iface_id, *, prefix=''):
         """Reparent an interface under another interface.  Returns True on success."""
         if self._db_manager is None:
             return False
@@ -1125,7 +1127,7 @@ def make_subinterface(self, iface_id, target_parent_iface_id):
             iface.parent_interface_id = target_parent_iface_id
             iface_name = iface.name
             session.commit()
-            self._db_manager.save_state(f'Make subinterface {iface_name}')
+            self._db_manager.save_state(f'{prefix}Make subinterface {iface_name}')
         except Exception:
             session.rollback()
             raise