Fix Hold Notes Position, maybe?

Author: LBO44

play/src/engine/playData/archetypes/Line.ts

@@ -40,7 +40,6 @@ export class Line extends Archetype {
   }
 
   updateParallel() {
-    debug.log(this.import.SpawnBeat * 10000 + time.now)
     if (this.despawnTime <= time.now) this.despawn = true
   }
 }

play/src/engine/playData/archetypes/LinePoint.ts

@@ -46,12 +46,14 @@ export class LinePoint extends Archetype {
   shouldSpawn() {
     return this.spawnTime <= time.now
   }
-  updateSequentialOrder = 10
 
   updateSequential() {
     this.pos.x = scaleX(this.hitTime, this.import.Canvas)
     this.pos.y = scaleY(this.import.YPos, this.import.Canvas)
-    this.lineY = this.updateLineYPos()
+    if (this.pos.x >= game.XMax) {
+      this.lineY = this.getLineYPos()
+      archetypes.Line.pos.get(this.import.Line).y = this.lineY
+    }
   }
 
 
@@ -86,13 +88,11 @@ export class LinePoint extends Archetype {
     skin.sprites.draw(spriteId, layout, 100, alpha)
   }
 
-  updateLineYPos(): number {
+  getLineYPos(): number {
     const n = archetypes.LinePoint.pos.get(this.import.NextPoint)
     const t = Math.clamp((game.XMax - this.pos.x) / (n.x - this.pos.x), 0, 1)
     const e = ease(t, this.import.EaseType)
-    const y = /**(this.pos.x === n.x) ? this.pos.y :*/ this.pos.y + e * (n.y - this.pos.y)
-    archetypes.Line.pos.get(this.import.Line).y = y
-    return y
+    return this.pos.y + e * (n.y - this.pos.y)
   }
 
   updateParallel() {

play/src/engine/playData/archetypes/notes/HoldEndNote.ts

@@ -76,8 +76,7 @@ export class HoldEndNote extends Archetype {
 
   getPos() {
     const lineY = archetypes.Line.pos.get(this.import.Line).y //TODO - not working
-    // this.pos.y = (time.now <= this.startTime) ? this.sharedMemory.fakeY : lineY
-    this.pos.y = this.sharedMemory.fakeY
+    this.pos.y = (time.now <= this.startTime) ? this.sharedMemory.fakeY : lineY
 
     const StartExist = entityInfos.get(this.import.HoldStart).state == EntityState.Active
     this.pos.xStart = StartExist ? archetypes.HoldNote.sharedMemory.get(this.import.HoldStart).pos.x : game.XMax