From de763f4a18b3dcc6f34a439ac8a02f474e7450d2 Mon Sep 17 00:00:00 2001 From: Ritesh Giram Date: Sat, 6 Jun 2026 13:04:11 +0000 Subject: [PATCH] optimized test helper to accept pointer parameter Signed-off-by: Ritesh Giram --- .../ratelimitpolicy_grpcroute_test.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/common/ratelimitpolicy/ratelimitpolicy_grpcroute_test.go b/tests/common/ratelimitpolicy/ratelimitpolicy_grpcroute_test.go index 4a00aff7f..3bebe5af3 100644 --- a/tests/common/ratelimitpolicy/ratelimitpolicy_grpcroute_test.go +++ b/tests/common/ratelimitpolicy/ratelimitpolicy_grpcroute_test.go @@ -148,7 +148,7 @@ var _ = Describe("RateLimitPolicy controller (GRPCRoute)", func() { } limitsNamespace := limitsNamespaceForGRPCRoute(grpcRoute) limitKey := limitKeyForGRPCPath(client.ObjectKeyFromObject(policy), "l1") - return limitadorLimitsContain(*limitador, limitsNamespace, limitKey) + return limitadorLimitsContain(limitador, limitsNamespace, limitKey) }).WithContext(ctx).Should(BeTrue()) }, testTimeOut) @@ -177,7 +177,7 @@ var _ = Describe("RateLimitPolicy controller (GRPCRoute)", func() { } limitsNamespace := limitsNamespaceForGRPCRoute(grpcRoute) limitKey := limitKeyForGRPCPath(client.ObjectKeyFromObject(policy), "l1") - return limitadorLimitsContain(*limitador, limitsNamespace, limitKey) + return limitadorLimitsContain(limitador, limitsNamespace, limitKey) }).WithContext(ctx).Should(BeTrue()) }, testTimeOut) @@ -233,12 +233,12 @@ var _ = Describe("RateLimitPolicy controller (GRPCRoute)", func() { // Route policy limit for grpcRoute routeLimitsNamespace := limitsNamespaceForGRPCRoute(grpcRoute) routeLimitKey := limitKeyForGRPCPath(client.ObjectKeyFromObject(routePolicy), "l1") - hasRouteLimit := limitadorLimitsContain(*limitador, routeLimitsNamespace, routeLimitKey) + hasRouteLimit := limitadorLimitsContain(limitador, routeLimitsNamespace, routeLimitKey) // Gateway policy limit for policyless route gwLimitsNamespace := limitsNamespaceForGRPCRoute(otherRoute) gwLimitKey := limitKeyForGRPCPath(client.ObjectKeyFromObject(gwPolicy), "gw-limit") - hasGWLimit := limitadorLimitsContain(*limitador, gwLimitsNamespace, gwLimitKey) + hasGWLimit := limitadorLimitsContain(limitador, gwLimitsNamespace, gwLimitKey) return hasRouteLimit && hasGWLimit }).WithContext(ctx).Should(BeTrue()) @@ -266,7 +266,7 @@ var _ = Describe("RateLimitPolicy controller (GRPCRoute)", func() { } limitsNamespace := limitsNamespaceForGRPCRoute(grpcRoute) limitKey := limitKeyForGRPCPath(client.ObjectKeyFromObject(policy), "l1") - return limitadorLimitsContain(*limitador, limitsNamespace, limitKey) + return limitadorLimitsContain(limitador, limitsNamespace, limitKey) }).WithContext(ctx).Should(BeTrue()) // delete policy @@ -281,7 +281,7 @@ var _ = Describe("RateLimitPolicy controller (GRPCRoute)", func() { } limitsNamespace := limitsNamespaceForGRPCRoute(grpcRoute) limitKey := limitKeyForGRPCPath(client.ObjectKeyFromObject(policy), "l1") - return !limitadorLimitsContain(*limitador, limitsNamespace, limitKey) + return !limitadorLimitsContain(limitador, limitsNamespace, limitKey) }).WithContext(ctx).Should(BeTrue()) }, testTimeOut) }) @@ -289,7 +289,7 @@ var _ = Describe("RateLimitPolicy controller (GRPCRoute)", func() { }) // limitadorLimitsContain checks if limitador contains a limit with the given namespace and identifier -func limitadorLimitsContain(limitador limitadorv1alpha1.Limitador, namespace, identifier string) bool { +func limitadorLimitsContain(limitador *limitadorv1alpha1.Limitador, namespace, identifier string) bool { expected := fmt.Sprintf(`descriptors[0]["%s"] == "1"`, identifier) for _, limit := range limitador.Spec.Limits { if limit.Namespace != namespace {