Skip to content

Warn user when Vulkan-Headers dependency and generated version differ when building #1710

Description

@sfan5

if you build vulkan-loader with the latest vulkan-headers (as of KhronosGroup/Vulkan-Headers@b11eecd) the build fails:

FAILED: loader/CMakeFiles/vulkan.dir/loader.c.obj 
  /usr/bin/ccache  x86_64-w64-mingw32-gcc-posix -DHAVE_CET_H -DUNKNOWN_FUNCTIONS_SUPPORTED -DVK_ENABLE_BETA_EXTENSIONS -DVK_USE_PLATFORM_WIN32_KHR -Dvulkan_EXPORTS -I/home/runner/work/mpv/mpv/Vulkan-Loader/loader -I/home/runner/work/mpv/mpv/Vulkan-Loader/loader/generated -I/home/runner/work/mpv/mpv/Vulkan-Loader/builddir/loader -isystem /home/runner/work/mpv/mpv/mingw_prefix/usr/local/include -O2 -pipe -Wall -Wno-error=deprecated -Wno-error=deprecated-declarations -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -O3 -DNDEBUG -std=c99 -fvisibility=hidden -Wall -Wextra -Wno-missing-field-initializers -fno-strict-aliasing -Wno-stringop-truncation -Wno-stringop-overflow -Wshadow=local -Wpointer-arith -MD -MT loader/CMakeFiles/vulkan.dir/loader.c.obj -MF loader/CMakeFiles/vulkan.dir/loader.c.obj.d -o loader/CMakeFiles/vulkan.dir/loader.c.obj -c /home/runner/work/mpv/mpv/Vulkan-Loader/loader/loader.c
  In file included from ../loader/loader.c:76:
  ../loader/generated/vk_loader_extensions.c: In function ‘CmdDispatchTileQCOM’:
  ../loader/generated/vk_loader_extensions.c:7991:5: error: too few arguments to function ‘disp->CmdDispatchTileQCOM’
   7991 |     disp->CmdDispatchTileQCOM(commandBuffer);
        |     ^~~~

Now you probably just have to update some stuff, but I'm wondering if vulkan-loader 1.4.315 strictly only supports building with vulkan-headers 1.4.315?
If so, the build system should probably enforce that.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions