Misc refactor

Author: JustArchi

ArchiSteamFarm/Steam/Exchange/Trading.cs

@@ -32,7 +32,6 @@
 using ArchiSteamFarm.Plugins;
 using ArchiSteamFarm.Steam.Cards;
 using ArchiSteamFarm.Steam.Data;
-using ArchiSteamFarm.Steam.Integration;
 using ArchiSteamFarm.Steam.Storage;
 using ArchiSteamFarm.Storage;
 using ArchiSteamFarm.Web;
@@ -43,6 +42,7 @@ namespace ArchiSteamFarm.Steam.Exchange;
 
 public sealed class Trading : IDisposable {
 	internal const byte MaxItemsPerTrade = byte.MaxValue; // This is decided upon various factors, mainly stability of Steam servers when dealing with huge trade offers
+	internal const byte MaxTradeHoldDuration = 15; // This is assumption based on existing observations
 	internal const byte MaxTradesPerAccount = 5; // This is limit introduced by Valve
 
 	private readonly Bot Bot;
@@ -513,7 +513,7 @@ private async Task<ParseTradeResult> ParseTrade(TradeOffer tradeOffer, ISet<(uin
 		byte maxTradeHoldDuration = ASF.GlobalConfig?.MaxTradeHoldDuration ?? GlobalConfig.DefaultMaxTradeHoldDuration;
 
 		// We assume that steam trade hold duration can't exceed the max, so skip the fetch unless we need it for blacklist handling or a lower configured limit
-		if (hasBlacklistedCards || (maxTradeHoldDuration < ArchiHandler.MaxTradeHoldDuration)) {
+		if (hasBlacklistedCards || (maxTradeHoldDuration < MaxTradeHoldDuration)) {
 			byte? holdDuration = await Bot.GetTradeHoldDuration(tradeOffer.OtherSteamID64, tradeOffer.TradeOfferID).ConfigureAwait(false);
 
 			switch (holdDuration) {

ArchiSteamFarm/Steam/Integration/ArchiHandler.cs

@@ -54,7 +54,6 @@ namespace ArchiSteamFarm.Steam.Integration;
 
 public sealed class ArchiHandler : ClientMsgHandler, IDisposable {
 	internal const byte MaxGamesPlayedConcurrently = 32; // This is limit introduced by Steam Network
-	internal const byte MaxTradeHoldDuration = 15; // This is assumption based on existing observations
 
 	private readonly ArchiLogger ArchiLogger;
 	private readonly SemaphoreSlim InventorySemaphore = new(1, 1);

ArchiSteamFarm/Storage/GlobalConfig.cs

@@ -37,6 +37,7 @@
 using ArchiSteamFarm.Helpers.Json;
 using ArchiSteamFarm.IPC.Integration;
 using ArchiSteamFarm.Localization;
+using ArchiSteamFarm.Steam.Exchange;
 using ArchiSteamFarm.Steam.Integration;
 using JetBrains.Annotations;
 using SteamKit2;
@@ -100,7 +101,7 @@ public sealed class GlobalConfig {
 	public const byte DefaultMaxFarmingTime = 10;
 
 	[PublicAPI]
-	public const byte DefaultMaxTradeHoldDuration = ArchiHandler.MaxTradeHoldDuration;
+	public const byte DefaultMaxTradeHoldDuration = Trading.MaxTradeHoldDuration;
 
 	[PublicAPI]
 	public const byte DefaultMinFarmingDelayAfterBlock = 60;