Skip to content

add Object.assign transform#122

Open
ianwith wants to merge 1 commit into
JedWatson:masterfrom
ianwith:master
Open

add Object.assign transform#122
ianwith wants to merge 1 commit into
JedWatson:masterfrom
ianwith:master

Conversation

@ianwith

@ianwith ianwith commented Apr 23, 2018

Copy link
Copy Markdown

Problem

Object.assign breaks on iOS versions < 9

Solution

  1. add babel-plugin-transform-object-assign
  2. npm run build

@dcousens

Copy link
Copy Markdown
Collaborator

@ianwith can't you do this yourself for your own project? :/

@ianwith

ianwith commented Apr 24, 2018

Copy link
Copy Markdown
Author

I'm using babel-runtime in my project. Am I supposed to change configuration like this?

Before

{
  test: /\.(js|jsx)$/,
  exclude: /node_modules/,
  use: 'babel-loader'
},

After

{
  test: /\.(js|jsx)$/,
  include: [
    path.resolve(__dirname, 'src'),
    path.resolve(__dirname, 'node_modules/react-tappable')
  ],
  use: 'babel-loader'
},

@dcousens

Copy link
Copy Markdown
Collaborator

@ianwith depends on how you are compiling. Did the above succeed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants