Merge branch 'develop' into master for v5.1.2

Author: JCMais

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Breaking Change
 
 ### Fixed
+- Fixed Windows source builds against Node.js 26 failing with `LINK : fatal error LNK1117: syntax error in option 'opt:lldltojobs=2'`. Node 26 was built with clang-cl + lld + ThinLTO (PR [nodejs/node#63114](https://github.com/nodejs/node/pull/63114), released in v26.3.0), and node-gyp's `create-config-gypi.js` seeds the addon's `config.gypi` from `process.config` of the running Node binary — picking up `enable_thin_lto: true` and `lto_jobs: <n>` from how Node itself was built. Node's installed `common.gypi` then unconditionally appends `-flto=thin` to MSVC `cl.exe`'s `AdditionalOptions` and `/opt:lldltojobs=<n>` to `link.exe`'s. MSVC ignores `-flto=thin` (warning) but rejects `/opt:lldltojobs=<n>` because `/OPT:` only accepts `REF/ICF/NOREF/NOICF/LBR/NOLBR`. Force them off via `npm_config_enable_thin_lto=false` + `npm_config_enable_lto=false` in the Windows build script, which node-gyp forwards as `-Denable_thin_lto=false` gyp defines (top precedence — `binding.gyp` `variables` don't override `config.gypi`'s, they're a separate gyp scope).
 
 ### Added
 

scripts/ci/windows/build.ps1

@@ -162,11 +162,30 @@ $env:npm_config_dist_url = $dist_url
 $env:npm_config_target = $target
 $env:npm_config_node_gyp = $globalNodeGypPath
 
+# Disable LTO/ThinLTO for the addon build. Node 26 ships with
+# enable_thin_lto=true baked into process.config because the Node binary
+# itself was built with clang-cl + lld + ThinLTO (PR nodejs/node#63114,
+# released in v26.3.0). node-gyp's create-config-gypi.js seeds config.gypi
+# from process.config when neither --nodedir nor --dist-url is set, so
+# common.gypi's `enable_thin_lto=="true"` conditions fire and emit
+# `-flto=thin` to cl.exe and `/opt:lldltojobs=<n>` to link.exe. Those are
+# clang-cl/lld-link flags; MSVC's cl.exe warns and ignores `-flto=thin`,
+# but link.exe rejects `/opt:lldltojobs=<n>` with `LNK1117` because
+# /OPT: only accepts REF/ICF/NOREF/NOICF/LBR/NOLBR.
+#
+# Setting npm_config_enable_thin_lto/enable_lto here makes node-gyp
+# forward them as `-Denable_thin_lto=false -Denable_lto=false` gyp
+# defines, which take precedence over config.gypi (binding.gyp variables
+# don't — they're a separate scope and lose to config.gypi).
+$env:npm_config_enable_thin_lto = "false"
+$env:npm_config_enable_lto = "false"
+
 Write-Host "Build configuration:" -ForegroundColor Green
 Write-Host "  npm_config_build_from_source: $env:npm_config_build_from_source" -ForegroundColor Cyan
 Write-Host "  npm_config_runtime: $env:npm_config_runtime" -ForegroundColor Cyan
 Write-Host "  npm_config_dist_url: $env:npm_config_dist_url" -ForegroundColor Cyan
 Write-Host "  npm_config_target: $env:npm_config_target" -ForegroundColor Cyan
+Write-Host "  npm_config_enable_thin_lto: $env:npm_config_enable_thin_lto" -ForegroundColor Cyan
 
 # Install dependencies and build
 Write-Host "Installing dependencies..." -ForegroundColor Blue