Commit b797528
fix(.editorconfig): restore CA1052 suggestion severity
Cherry-pick dfd7ac3 ("Fix CA1052 in the codebase") removed the
CA1052 severity downgrade in src/Microsoft.DotNet.Wpf/src/.editorconfig
and converted some static-holder types to actually be static. But the
upstream PR (dotnet#10718) is still OPEN — h3xds1nz never finished fixing
all violations. Three types still trigger CA1052 in our cherry-picked
state:
- MarshalGeneric<T> (Marshalers.cs L339) — base class, not
convertible to static; would need to become `abstract`
- XamlParser (XamlParser.cs L58) — constructors guarded
by #if PBTCOMPILER; non-PBT build has only statics
- XamlReaderHelper (XamlReaderConstants.cs L28) — partial class
upstream/main still has `dotnet_diagnostic.CA1052.severity = suggestion`
in this same .editorconfig — so we match upstream's current state.
Properly finishing upstream PR 10718 (making the three types static/
sealed/abstract correctly) is queued for a follow-up — see FORK.md
"Conflicted PRs" list.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 7715979 commit b797528
1 file changed
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
20 | 29 | | |
21 | 30 | | |
22 | 31 | | |
| |||
0 commit comments