Skip to content

Hard-coding editor.js goes against SDK best practice #2

Description

@tomtom215

Loving the work here, however after reading through your component and the Creative SDK page, it explicitly states to call the Javascript Editor Url directly as there are server-side dependencies. (snip from the SDK site)

image

I noticed that you have minified and hard-coded this endpoint under your /scripts directory.

I feel that this could lead to issues if there are any changes made by Adobe/Aviary when using this component with that script localized as-is

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions