Merge pull request #162 from ImagingDataCommons/revert-161-chore/update-to-0.45.4

Revert "chore: update to slim 0.45.4"

Author: igoroctaviano

.eslintrc.strict.cjs

@@ -15,16 +15,19 @@ jobs:
       - name: Checkout to repository
         uses: actions/checkout@v4.2.2
 
-      - name: Setup Bun
-        uses: oven-sh/setup-bun@v2
+      - name: Setup Node
+        uses: actions/setup-node@v4.4.0
         with:
-          bun-version: latest
+          node-version: 20.8.1
+
+      - name: Install Yarn
+        run: sudo npm i -g yarn
 
       - name: Install dependencies
-        run: bun install --frozen-lockfile
+        run: yarn
 
       - name: Build
-        run: REACT_APP_CONFIG=preview PUBLIC_URL=/ bun run build
+        run: REACT_APP_CONFIG=preview PUBLIC_URL=/ yarn build
 
       - name: Deploy
         uses: FirebaseExtended/action-hosting-deploy@v0

.github/workflows/deploy-to-firebase.yml

@@ -6,10 +6,6 @@ on:
   pull_request:
     branches: [master]
 
-concurrency:
-  group: deploy-gh-pages
-  cancel-in-progress: true
-
 jobs:
   deploy-to-github-pages:
     name: "Deploy to GitHub Pages"
@@ -18,17 +14,20 @@ jobs:
       - name: Checkout to repository
         uses: actions/checkout@v4.2.2
 
-      - name: Setup Bun
-        uses: oven-sh/setup-bun@v2
+      - name: Setup Node
+        uses: actions/setup-node@v4.4.0
         with:
-          bun-version: latest
+          node-version: 20.8.1
+
+      - name: Install Yarn
+        run: sudo npm i -g yarn
 
       - name: Install dependencies
-        run: bun install --frozen-lockfile
+        run: yarn
 
       - name: Build and deploy to GitHub Pages
         run: |
           git remote set-url origin https://git:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY}.git
-          bun run deploy -- -u "github-actions-bot <support+actions@github.com>" -f
+          yarn deploy -- -u "github-actions-bot <support+actions@github.com>"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/deploy-to-github-pages.yml

@@ -16,16 +16,16 @@ jobs:
           ref: master
           persist-credentials: false
 
-      - name: Setup Bun
-        uses: oven-sh/setup-bun@v2
+      - name: Setup Node
+        uses: actions/setup-node@v4.4.0
         with:
-          bun-version: latest
+          node-version: 20.8.1
 
       - name: Install dependencies
-        run: bun install --frozen-lockfile
+        run: yarn
 
       - name: Build
-        run: bun run build
+        run: yarn build
 
       - name: Zip build
         run: zip -r build.zip build
@@ -37,4 +37,4 @@ jobs:
           GIT_AUTHOR_EMAIL: ${{ vars.RELEASE_GIT_AUTHOR_EMAIL }}
           GIT_COMMITTER_NAME: ${{ vars.RELEASE_GIT_COMMITTER_NAME }}
           GIT_COMMITTER_EMAIL: ${{ vars.RELEASE_GIT_COMMITTER_EMAIL }}
-        run: bunx semantic-release --branches master
+        run: npx semantic-release --branches master

.github/workflows/release.yml

@@ -14,19 +14,19 @@ jobs:
       - name: Checkout to repository
         uses: actions/checkout@v4.2.2
 
-      - name: Setup Bun
-        uses: oven-sh/setup-bun@v2
+      - name: Setup Node
+        uses: actions/setup-node@v4.4.0
         with:
-          bun-version: latest
+          node-version: 20.8.1
 
       - name: Install dependencies
-        run: bun install --frozen-lockfile
+        run: yarn
 
       - name: Build
-        run: bun run build
+        run: yarn build
 
       - name: Lint
-        run: bun run lint
+        run: yarn lint
 
       - name: Test
-        run: bun run test
+        run: yarn test

.github/workflows/unit-tests.yml

@@ -12,8 +12,6 @@
 /coverage
 .env
 
-.cursorrules
-
 # production
 /build
 
@@ -30,7 +28,7 @@ public/config/*
 .env.production.local
 
 npm-debug.log*
-bun-debug.log*
-bun-error.log*
+yarn-debug.log*
+yarn-error.log*
 
 /.github

.gitignore

@@ -31,17 +31,15 @@ The app is built using [craco](https://github.com/gsoft-inc/craco) (with the [cr
 
 Tests are written and run using the [jest](https://jestjs.io/) framework.
 
-The [Bun](https://bun.sh/) runtime and package manager is used to manage dependencies and run scripts specified in `package.json` (`build`, `lint`, `test`, etc.).
+The [yarn](https://yarnpkg.com/) package manager is used to manage dependencies and run scripts specified in `package.json` (`build`, `lint`, `test`, etc.).
 
 ## Coding style
 
-Source code is linted and formatted using [Biome](https://biomejs.dev/). TypeScript is used with [strict type checking compiler options](https://www.typescriptlang.org/tsconfig#Strict_Type_Checking_Options_6173) enabled. Semicolons are not used at the end of statements (Biome uses `asNeeded`).
+Source code is linted using [ts-standard](https://github.com/standard/ts-standard) (based on [eslint](https://eslint.org/)) and TypeScript is used with [strict type checking compiler options](https://www.typescriptlang.org/tsconfig#Strict_Type_Checking_Options_6173) enabled.
 
-Use the following commands to check and fix style:
+Use the following command to identify potential coding style and type annotation violations:
 
-    $ bun run lint        # check for issues
-    $ bun run lint:fix    # auto-fix issues
-    $ bun run fmt         # format code
+    $ yarn lint
 
 
 ### Documentation

.husky/pre-commit

@@ -10,37 +10,35 @@ RUN apt-get update && \
     curl \
     dumb-init \
     gnupg \
-    nginx \
-    unzip && \
+    nginx && \
     apt-get clean
 
 RUN curl -fsSL https://deb.nodesource.com/setup_21.x | bash - && \
+    curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - && \
+    echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list && \
+    curl -sS https://deb.nodesource.com/setup_21.x | bash - && \
     apt-get update && \
     apt-get install -y --no-install-suggests --no-install-recommends \
-    nodejs && \
+    nodejs \
+    yarn && \
     apt-get clean
 
-# Install Bun (matches packageManager in package.json)
-ENV BUN_INSTALL=/usr/local
-RUN curl -fsSL https://bun.sh/install | bash -
-
 WORKDIR /usr/local/share/mghcomputationalpathology/slim
 
 # Install dependencies first and then include code for efficient caching
 COPY package.json .
-COPY bun.lock .
+COPY yarn.lock .
 
-RUN bun install --frozen-lockfile
+# There are sometimes weird network errors. Increasing the network timeout
+#  seems to help (see https://github.com/yarnpkg/yarn/issues/5259)
+RUN yarn install --frozen-lockfile --network-timeout 100000
 
 COPY craco.config.js .
 COPY tsconfig.json .
 COPY types ./types
 COPY public ./public
-COPY scripts ./scripts
 COPY src ./src
 
-RUN chmod +x scripts/*.sh
-
 
 FROM lib AS app
 
@@ -56,7 +54,7 @@ RUN addgroup --system --gid 101 nginx && \
             --shell /bin/false \
             nginx
 
-RUN NODE_OPTIONS=--max_old_space_size=8192 bun run build && \
+RUN NODE_OPTIONS=--max_old_space_size=8192 yarn run build && \
         mkdir -p /var/www/html && \
         cp -R build/* /var/www/html/
 
@@ -81,4 +79,4 @@ RUN useradd -m -s /bin/bash tester && \
 
 USER tester
 
-ENTRYPOINT ["/usr/bin/dumb-init", "--", "bun", "run", "test"]
+ENTRYPOINT ["/usr/bin/dumb-init", "--", "yarn", "test"]