Fix typos in disconnect functions (#48)

* Fix typos in disconnect functions

* Fix unit tests

* Add Python 3.14 to tests

Author: Monarda

.github/workflows/build.yaml

@@ -35,7 +35,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest] #, mac-latest]
-        python-version: ["3.10", "3.11", "3.12", "3.13"]
+        python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
     runs-on: ${{ matrix.os }}
     continue-on-error: true
     steps:

p4pillon/composite_handler.py

@@ -86,13 +86,13 @@ def on_first_connect(self, pv: SharedPV):
     def onFirstConnect(self, pv: Value):
         self.on_first_connect(pv)
 
-    def on_last_connect(self, pv: SharedPV):
+    def on_last_disconnect(self, pv: SharedPV):
         """Called when the last client channel is closed."""
         for handler in self.values():
-            handler.onFirstConnect(pv)
+            handler.onLastDisconnect(pv)
 
     def onLastDisconnect(self, pv: Value):
-        self.on_last_connect(pv)
+        self.on_last_disconnect(pv)
 
     def close(self, pv: SharedPV):
         for handler in self.values():

pyproject.toml

@@ -84,7 +84,4 @@ extend-select = [
   "I", # isort
 ]
 
-[tool.uv.sources]
-p4p = { git = "https://github.com/epics-base/p4p" }
-
 

tests/unit/test_composite_handler.py

@@ -29,6 +29,9 @@ def rpc(self, pv, op):
     def onFirstConnect(self, pv):
         self.calls.append(("onFirstConnect", pv))
 
+    def onLastDisconnect(self, pv):
+        self.calls.append(("onLastDisconnect", pv))
+
     def close(self, pv):
         self.calls.append(("close", pv))
 
@@ -136,18 +139,18 @@ def test_onFirstConnect_deprecated(self):
         self.comp.onFirstConnect(self.pv)
         self.assertEqual(self.h1.calls[0], ("onFirstConnect", self.pv))
 
-    def test_on_last_connect_calls_all(self):
-        self.comp.on_last_connect(self.pv)
-        self.assertEqual(self.h1.calls[0], ("onFirstConnect", self.pv))
-        self.assertEqual(self.h2.calls[0], ("onFirstConnect", self.pv))
+    def test_on_last_disconnect_calls_all(self):
+        self.comp.on_last_disconnect(self.pv)
+        self.assertEqual(self.h1.calls[0], ("onLastDisconnect", self.pv))
+        self.assertEqual(self.h2.calls[0], ("onLastDisconnect", self.pv))
 
-    def test_on_last_connect_no_handlers(self):
+    def test_on_last_disconnect_no_handlers(self):
         comp = CompositeHandler()
-        comp.on_last_connect(self.pv)  # Should not raise
+        comp.on_last_disconnect(self.pv)  # Should not raise
 
     def test_onLastDisconnect_deprecated(self):
         self.comp.onLastDisconnect(self.pv)
-        self.assertEqual(self.h1.calls[0], ("onFirstConnect", self.pv))
+        self.assertEqual(self.h1.calls[0], ("onLastDisconnect", self.pv))
 
     def test_close_calls_all(self):
         self.comp.close(self.pv)