Skip to content

Commit f3a9356

Browse files
committed
fix: raise statistics daily goal limits
1 parent 56df1cb commit f3a9356

3 files changed

Lines changed: 27 additions & 3 deletions

File tree

app/src/main/java/moe/antimony/hoshi/features/statistics/StatisticsModels.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,11 @@ internal data class StatisticsTargetSettings(
6666
internal object StatisticsTargetDefaults {
6767
const val DailyCharacterTarget = 5_000
6868
const val MinDailyCharacterTarget = 500
69-
const val MaxDailyCharacterTarget = 20_000
69+
const val MaxDailyCharacterTarget = 200_000
7070
const val DailyCharacterTargetStep = 500
7171
const val DailyDurationTargetMinutes = 30
7272
const val MinDailyDurationTargetMinutes = 5
73-
const val MaxDailyDurationTargetMinutes = 240
73+
const val MaxDailyDurationTargetMinutes = 720
7474
const val DailyDurationTargetStepMinutes = 5
7575
const val WeeklyTargetDays = 4
7676
const val MinWeeklyTargetDays = 1

app/src/test/java/moe/antimony/hoshi/features/statistics/StatisticsSettingsRepositoryTest.kt

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,14 +74,34 @@ class StatisticsSettingsRepositoryTest {
7474
StatisticsTargetSettings(
7575
dailyTargetType = DailyTargetType.Duration,
7676
dailyCharacterTarget = 500,
77-
dailyDurationTargetMinutes = 240,
77+
dailyDurationTargetMinutes = 720,
7878
weeklyTargetDays = 7,
7979
),
8080
repository.settings.first(),
8181
)
8282
}
8383
}
8484

85+
@Test
86+
fun clampsDailyTargetsAtExpandedCeilings() = runBlocking {
87+
repository().use { repository ->
88+
repository.update {
89+
it.copy(
90+
dailyCharacterTarget = 250_000,
91+
dailyDurationTargetMinutes = 999,
92+
)
93+
}
94+
95+
assertEquals(
96+
StatisticsTargetSettings(
97+
dailyCharacterTarget = 200_000,
98+
dailyDurationTargetMinutes = 720,
99+
),
100+
repository.settings.first(),
101+
)
102+
}
103+
}
104+
85105
@Test
86106
fun snapsTargetValuesToSupportedSteps() = runBlocking {
87107
repository().use { repository ->

docs/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ Historical release notes before v1.3.0 live in [CHANGELOG_ARCHIVE.md](CHANGELOG_
66

77
## [Unreleased]
88

9+
### Changed
10+
11+
- Raise Statistics daily goal limits to 200,000 characters and 12 hours.
12+
913
### Fixed
1014

1115
- Keep the Statistics tab visible after enabling it and switching away from Settings.

0 commit comments

Comments
 (0)