Merge pull request #24 from HitsukiMok/jim/improved-yancy-task

fix: found and fix the issue on the messaging system

Author: Jimuelle07

backend/src/config/socket.js

@@ -74,18 +74,14 @@ export const initializeSocket = (httpServer) => {
 
     // ── send_message ───────────────────────────────────────────────────────────
     socket.on('send_message', async ({ conversationId, itemId, content }) => {
-      console.log('[send_message] received', { conversationId, itemId, userId: socket.data.userId, contentLen: content?.length });
-
       if (!conversationId || !itemId || !content?.trim()) {
-        console.warn('[send_message] REJECTED — missing field', { conversationId: !!conversationId, itemId: !!itemId, hasContent: !!content?.trim() });
         socket.emit('error', { message: 'conversationId, itemId, and content are required' });
         return;
       }
 
       try {
         const conversation = await Conversation.findById(conversationId);
         if (!conversation) {
-          console.warn('[send_message] REJECTED — conversation not found:', conversationId);
           socket.emit('error', { message: 'Conversation not found' });
           return;
         }
@@ -95,10 +91,7 @@ export const initializeSocket = (httpServer) => {
         const isReporterSender = conversation.reporter.toString() === userId;
         const isFinderSender = conversation.finder.toString() === userId;
 
-        console.log('[send_message] auth check', { reporter: conversation.reporter.toString(), finder: conversation.finder.toString(), userId, isReporterSender, isFinderSender });
-
         if (!isReporterSender && !isFinderSender) {
-          console.warn('[send_message] REJECTED — not a participant');
           socket.emit('error', { message: 'Not authorized to send messages in this conversation' });
           return;
         }
@@ -133,15 +126,13 @@ export const initializeSocket = (httpServer) => {
           }
         }
 
-        console.log('[send_message] creating message', { conversationId, itemId, sender: userId, receiver: receiverId });
         const newMessage = await Message.create({
           conversation: conversationId,
           item: itemId,
           sender: userId,
           receiver: receiverId,
           content: content.trim(),
         });
-        console.log('[send_message] message saved to DB:', newMessage._id.toString());
 
         // Update conversation timestamp manually
         conversation.updatedAt = new Date();
@@ -168,7 +159,7 @@ export const initializeSocket = (httpServer) => {
           isMuted: conversation.mutedBy && conversation.mutedBy.some(id => id.toString() === receiverId)
         });
       } catch (err) {
-        console.error(`[send_message] CAUGHT ERROR (room: ${conversationId}):`, err);
+        console.error(`send_message error (room: ${conversationId}):`, err.message);
         socket.emit('error', { message: 'Failed to send message. Please try again.' });
       }
     });

frontend/src/ItemDetailPage/ChatPanel.jsx

@@ -165,7 +165,6 @@ export default function ChatPanel({ itemId, conversationId: initialConvId, curre
       socket.emit('stop_typing', { conversationId: activeConvId })
     }
 
-    console.log('[ChatPanel] emitting send_message', { conversationId: activeConvId, itemId, socketConnected: socket?.connected })
     socket.emit('send_message', {
       conversationId: activeConvId,
       itemId,

frontend/src/context/SocketContext.jsx

@@ -3,7 +3,7 @@ import { io } from 'socket.io-client';
 
 const SocketContext = createContext(null);
 
-const SOCKET_URL = import.meta.env.VITE_SOCKET_URL || 'http://localhost:5000';
+const SOCKET_URL = import.meta.env.VITE_SOCKET_URL || import.meta.env.VITE_API_URL || 'http://localhost:5000';
 
 function getStoredToken() {
   return localStorage.getItem('kyurToken');