refactor: update template synchronization logic and improve error handling

Author: recepgunes1

cmd/vt/main.go

@@ -13,7 +13,6 @@ func main() {
 	logger.Init()
 	templates.Init()
 
-	// Print the banner
 	banner.Print()
 
 	// Run the CLI

internal/cli/list.go

@@ -51,7 +51,7 @@ var templateCmd = &cobra.Command{
 		}
 
 		if update {
-			templates.Update()
+			templates.SyncTemplates()
 			return
 		}
 	},

pkg/templates/downloader.go

@@ -1,6 +1,7 @@
 package templates
 
 import (
+	"errors"
 	"fmt"
 	"os"
 
@@ -20,10 +21,8 @@ func cloneTemplatesRepo(repoPath string, force bool) error {
 			return err
 		}
 
-		if !force {
-			if !status.IsClean() {
-				return fmt.Errorf("detected uncomitted changes in %s", repoPath)
-			}
+		if !force && !status.IsClean() {
+			return fmt.Errorf("detected uncommitted changes in %s", repoPath)
 		}
 
 		err = worktree.Pull(&git.PullOptions{
@@ -38,16 +37,25 @@ func cloneTemplatesRepo(repoPath string, force bool) error {
 		return nil
 	}
 
+	err = os.RemoveAll(repoPath)
+	if err != nil {
+		return err
+	}
+
 	if err := os.MkdirAll(repoPath, 0750); err != nil {
 		return err
 	}
 
 	_, err = git.PlainClone(repoPath, false, &git.CloneOptions{
-		URL:   "https://github.com/HappyHackingSpace/vt-templates",
+		URL:   TemplateRemoteRepoistory,
 		Depth: 1,
 	})
 
 	if err != nil {
+		removeErr := os.RemoveAll(repoPath)
+		if removeErr != nil {
+			return errors.Join(err, fmt.Errorf("cleanup failed: %w", removeErr))
+		}
 		return err
 	}
 

pkg/templates/template.go

@@ -10,6 +10,9 @@ import (
 	"github.com/rs/zerolog/log"
 )
 
+// TemplateRemoteRepoistory is a constant for repo url.
+const TemplateRemoteRepoistory string = "https://github.com/HappyHackingSpace/vt-templates"
+
 // Template represents a vulnerable target environment configuration.
 type Template struct {
 	ID             string                    `yaml:"id"`
@@ -100,15 +103,15 @@ func Init() {
 	}
 }
 
-// Update loads all templates from remote repository (force).
-func Update() {
+// SyncTemplates downloads or updates all templates from the remote repository.
+func SyncTemplates() {
 	homeDir, err := os.UserHomeDir()
 	if err != nil {
 		log.Fatal().Msgf("%v", err)
 	}
 
 	repoPath := filepath.Join(homeDir, "vt-templates")
-	log.Info().Msgf("cloning github.com/HappyHackingSpace/vt-templates")
+	log.Info().Msgf("cloning %s", TemplateRemoteRepoistory)
 	err = cloneTemplatesRepo(repoPath, true)
 	if err != nil {
 		log.Fatal().Msgf("%v", err)