fix: Prevent autoloader loop crash on individual file fetch errors#917
Merged
Conversation
Contributor
Author
|
@EdwardMoyse can u review this pr when u get time ? |
Contributor
Author
|
@EdwardMoyse ,Thanks so much for the review and for merging this! I'd love to continue contributing. Are there any specific issues or upcoming features you'd recommend I look at next? Happy to take on something a bit more challenging if you have anything in mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Wrapped the
fetchAndEmit(fileUrl)call inside atry/catchblock within the directory polling loop.Why is this needed?
Previously, if a single file failed, the uncaught error would break the entire
forloop. This caused the autoloader to completely ignore any remaining new files in that batch.By isolating the fetch step, a failed file is now safely caught and passed to the
onErrorhandler, allowing the loop to continue processing the rest of the files without interruption.