Merge pull request #4678 from Growstuff/fix-photo-reindex-error-4629481995101950332

Fix NoMethodError: undefined method 'reindex' for class Photo in specs

Author: CloCkWeRX

app/controllers/likes_controller.rb

@@ -11,7 +11,7 @@ def create
       likeable_id:   params[:id]
     )
     if @like.likeable && @like.save
-      @like.likeable.reindex(refresh: true)
+      @like.likeable.reindex(refresh: true) if @like.likeable.respond_to?(:reindex)
       success(@like, liked_by_member: true, status_code: :created)
     else
       failed(@like, message: t('messages.unable_to_like'))
@@ -26,7 +26,7 @@ def destroy
     )
 
     if @like&.destroy
-      @like.likeable.reindex(refresh: true)
+      @like.likeable.reindex(refresh: true) if @like.likeable.respond_to?(:reindex)
       success(@like, liked_by_member: false, status_code: :ok)
     else
       failed(@like, message: t('messages.unable_to_unlike'))

spec/features/home/home_spec.rb

@@ -28,7 +28,6 @@
     Planting.reindex
     Seed.reindex
     Harvest.reindex
-    Photo.reindex
 
     visit root_path
   end

spec/features/likeable_spec.rb

@@ -6,14 +6,10 @@
   let(:another_member) { create(:london_member) }
   let!(:post)           { create(:post, :reindex, author: member) }
   let!(:activity)       { create(:activity, :reindex, owner: member) }
-  let!(:photo)          { create(:photo, :reindex, owner: member) }
+  let!(:photo)          { create(:photo, owner: member) }
   let!(:harvest)        { create(:harvest, :reindex, owner: member) }
   let!(:planting)       { create(:planting, :reindex, owner: member) }
 
-  before do
-    Photo.reindex
-  end
-
   include_context 'signed in member'
 
   shared_examples 'object can be liked' do

spec/spec_helper.rb

@@ -47,7 +47,6 @@ def index_everything
     # reindex models
     Crop.reindex
     Harvest.reindex
-    Photo.reindex
     Planting.reindex
     Seed.reindex
   end