Merge pull request #270 from Gigadrive/feature/typecheck-ci

feat: add typecheck CI step and fix Turborepo caching

Author: Zeryther

.github/workflows/test.yaml

@@ -77,12 +77,28 @@ jobs:
       - name: Prettier
         run: pnpm format
 
+  typecheck:
+    name: Type Check
+    runs-on: blacksmith-4vcpu-ubuntu-2204
+    timeout-minutes: 10
+    permissions:
+      contents: read
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup
+        uses: ./.github/actions/setup
+
+      - name: Type Check
+        run: pnpm typecheck
+
   summary:
     name: Summary (CI)
     runs-on: blacksmith-2vcpu-ubuntu-2204
     timeout-minutes: 5
     if: always()
-    needs: [test, lint, format]
+    needs: [test, lint, format, typecheck]
     permissions:
       contents: read
     steps:
@@ -91,8 +107,9 @@ jobs:
           TEST: ${{ needs.test.result }}
           LINT: ${{ needs.lint.result }}
           FORMAT: ${{ needs.format.result }}
+          TYPECHECK: ${{ needs.typecheck.result }}
         run: |
-          if [[ "$TEST" != "success" || "$LINT" != "success" || "$FORMAT" != "success" ]]; then
+          if [[ "$TEST" != "success" || "$LINT" != "success" || "$FORMAT" != "success" || "$TYPECHECK" != "success" ]]; then
             echo "One or more jobs failed or were cancelled."
             exit 1
           fi

AGENTS.md

@@ -28,11 +28,12 @@ pnpm build                # Build all packages (via Turborepo)
 pnpm build:no-cache       # Build without Turbo cache
 pnpm clean                # Remove all dist directories
 
-# Lint & Format
+# Lint, Format & Type Check
 pnpm lint                 # ESLint check
 pnpm lint:fix             # ESLint autofix
 pnpm format               # Prettier check
 pnpm format:fix           # Prettier autofix
+pnpm typecheck            # TypeScript type check (via Turborepo)
 
 # Test (Vitest)
 pnpm test                 # Run all tests once
@@ -49,8 +50,8 @@ pnpm vitest run -t "should merge two objects correctly"
 pnpm vitest run packages/commons/
 ```
 
-**CI runs three parallel checks on every PR:** `pnpm test`, `pnpm lint`, `pnpm format`.
-All three must pass.
+**CI runs four parallel checks on every PR:** `pnpm test`, `pnpm lint`, `pnpm format`, `pnpm typecheck`.
+All four must pass.
 
 ## Test Conventions
 

local/tsup/package.json

@@ -18,6 +18,7 @@
   "scripts": {
     "build": "tsup",
     "build:watch": "tsup --watch",
-    "preinstall": "pnpm build"
+    "preinstall": "pnpm build",
+    "typecheck": "tsc --noEmit"
   }
 }

package.json

@@ -22,7 +22,8 @@
     "lint:fix": "eslint --cache --fix --ext .ts,.tsx,.js,.jsx .",
     "test": "vitest run",
     "test:coverage": "vitest run --coverage",
-    "test:watch": "vitest"
+    "test:watch": "vitest",
+    "typecheck": "turbo run typecheck"
   },
   "devDependencies": {
     "@changesets/cli": "^2.29.7",

packages/build-utils/package.json

@@ -24,7 +24,8 @@
   ],
   "scripts": {
     "build": "tsup",
-    "clean": "rm -rf dist"
+    "clean": "rm -rf dist",
+    "typecheck": "tsc --noEmit"
   },
   "dependencies": {
     "archiver": "^7.0.1",

packages/cli/package.json

@@ -20,7 +20,8 @@
   "scripts": {
     "build": "tsup",
     "clean": "rm -rf dist",
-    "dev": "pnpm build && node dist/index.mjs"
+    "dev": "pnpm build && node dist/index.mjs",
+    "typecheck": "tsc --noEmit"
   },
   "dependencies": {
     "@effect/cli": "^0.73.2",

packages/cli/src/commands/build/index.ts

@@ -2,7 +2,7 @@ import { Command } from '@effect/cli';
 import { FileSystem, Path } from '@effect/platform';
 import { exec } from '@gigadrive/build-utils';
 import { Console, Effect } from 'effect';
-import { BuildScriptNotFoundError, ExecError, PackageJsonNotFoundError } from '../../errors';
+import { BuildScriptNotFoundError, ExecError, PackageJsonNotFoundError, PackageJsonParseError } from '../../errors';
 import { PackageManagerService } from '../../services/package-manager';
 
 export const buildCommand = Command.make('build', {}, () =>

packages/commons/package.json

@@ -24,7 +24,8 @@
   ],
   "scripts": {
     "build": "tsup",
-    "clean": "rm -rf dist"
+    "clean": "rm -rf dist",
+    "typecheck": "tsc --noEmit"
   },
   "devDependencies": {
     "@types/node": "^22.18.7"

packages/harmony/package.json

@@ -49,7 +49,8 @@
     "clean": "rm -rf dist",
     "storybook": "storybook dev -p 6006 --no-open",
     "storybook:build": "storybook build",
-    "storybook:build-docs": "storybook build --docs"
+    "storybook:build-docs": "storybook build --docs",
+    "typecheck": "tsc --noEmit -p tsconfig.check.json"
   },
   "dependencies": {
     "@dnd-kit/core": "^6.3.1",

packages/harmony/tsconfig.check.json

@@ -0,0 +1,4 @@
+{
+  "extends": "./tsconfig.json",
+  "include": ["src"]
+}