internal/worker/scripts: Add logging to hivex shell scripts

Signed-off-by: Max Asnaashari <max.asna@futurfusion.io>

Author: masnax

internal/worker/scripts/hivex-assign-netcfg.sh

@@ -7,8 +7,11 @@ hive_dir="${mount_dir}/Windows/System32/config/SYSTEM"
 old_guid_file="${mount_dir}/migration_manager_old_guids"
 nics_file="${mount_dir}/migration_manager_nics"
 
+echo "Setting up first-boot network reassignment script"
+
 # Just exit if no MACs provided.
 if [ 0 = ${#} ]; then
+  echo "No MACs supplied, exiting"
   exit 0
 fi
 
@@ -21,6 +24,8 @@ fi
 
 control_set="$(printf "ControlSet%03d" "${control_set_num}")"
 
+echo "Using control set ${control_set}"
+
 # Record each mapping of MAC to InstanceGUID because we can't tell which NIC is which after booting. (And also reading networksetup2 requires elevated privileges).
 # shellcheck disable=1003
 hivexregedit --export --prefix 'hklm\system' "${hive_dir}" "${control_set}\control\networksetup2\interfaces" --max-depth 3 \
@@ -32,18 +37,22 @@ hivexregedit --export --prefix 'hklm\system' "${hive_dir}" "${control_set}\contr
 
 # If we can't find any MACs, then exit.
 if [ "$(wc -l /tmp/macs_to_guids)" = 0 ]; then
+  echo "No GUID records found, exiting"
   exit 0
 fi
 
 # Remove the state files in case they exist.
 rm -rf "${old_guid_file}" "${nics_file}"
 
 for mac in "${@}" ; do
+  echo "  Checking mac ${mac}"
+
   # Grab the previous GUID for this MAC.
   mac="$(printf "%s" "${mac}" | tr '[:upper:]' '[:lower:]')"
   mapping="$(grep "^${mac}" -B1 --no-group-separator /tmp/macs_to_guids | head -2)"
 
   if [ -z "${mapping}" ] ; then
+    echo "  Mac ${mac} not found in GUID mappings"
     continue
   fi
 
@@ -52,9 +61,12 @@ for mac in "${@}" ; do
   mac="$(printf "%s" "${mac}" | tr '[:lower:]' '[:upper:]' | sed -e 's/:/-/g')"
 
   if [ -z "${old_guid}" ] || [ -z "${mac}" ]; then
+    echo "  Unexpected GUID mapping format: ${mapping}"
     exit 1
   fi
 
+  echo "  MAC: ${mac} GUID: ${old_guid}"
+
   echo "${old_guid}" >> "${old_guid_file}"
   echo "${mac}" >> "${nics_file}"
 done

internal/worker/scripts/hivex-cpu-hotplug-compat.sh

@@ -2,6 +2,8 @@
 
 set -e
 
+echo "Running Windows CPU-hotplug compatibility patches"
+
 mount_dir="/run/mount/win_main"
 hive_dir="${mount_dir}/Windows/System32/config"
 
@@ -13,14 +15,20 @@ remove_key="$(hivexregedit --export --prefix 'hklm\system' "${hive_dir}/SYSTEM"
 # Only perform the ACPI removal if the key is found.
 # See: https://forum.proxmox.com/threads/windows-2016-cpu-hot-plug-support.42302/
 if [ -n "${remove_key}" ]; then
+  echo "Removing invalid ACPI hidinterrupt.inf entry"
   cat << EOF | hivexregedit --merge --prefix 'HKLM\SYSTEM' "${hive_dir}/SYSTEM"
 [-DriverDatabase\DeviceIds\ACPI\ACPI0010]
 
 ${remove_key}
 
 EOF
+else
+  echo "Invalid ACPI hidinterrupt.inf entry not found, assuming Windows is patched"
 fi
 
+
+echo "Disabling VBS auto-start"
+
 # Disable Virtualization Based Security.
 cat << EOF | hivexregedit --merge --prefix 'HKLM\SYSTEM' "${hive_dir}/SYSTEM"
 [ControlSet001\Control]

internal/worker/scripts/hivex-disable-vm-tools.sh

@@ -5,6 +5,8 @@ set -e
 mount_dir="/run/mount/win_main"
 hive_dir="${mount_dir}/Windows/System32/config"
 
+echo "Cleaning up VMware tools"
+
 # No VMware tools, nothing to do.
 if ! test -e "${mount_dir}/Program Files/VMware/VMware Tools" ; then
   echo "VMware tools were not found"
@@ -327,3 +329,5 @@ rm -rf "${mount_dir}/ProgramData/VMware/VMware Tools"
 rm -rf "${mount_dir}/ProgramData/VMware/VMware VGAuth"
 rm -rf "${mount_dir}/Program Files/Common Files/VMware/Drivers"
 rm -rf "${mount_dir}/Program Files/Common Files/VMware/InstallerCache"
+
+echo "VMware Tools successfully cleaned up"

internal/worker/scripts/hivex-first-boot.sh

@@ -5,6 +5,8 @@ set -e
 mount_dir="/run/mount/win_main"
 hive_dir="${mount_dir}/Windows/System32/config/SYSTEM"
 
+echo "Setting up first-boot service"
+
 # Get the current control set before it's loaded.
 control_set_num="$(hivexregedit --export --prefix='HKEY_LOCAL_MACHINE\SYSTEM' "${hive_dir}" 'Select' | grep -io '^"Current"=dword:[0-9a-f]*' | cut -d':' -f2 | sed -e 's/^0*//')"
 
@@ -14,6 +16,8 @@ fi
 
 control_set="$(printf "ControlSet%03d" "${control_set_num}")"
 
+echo "Using control set ${control_set}"
+
 # Create a service that runs before any user boots. For some reason, we can't run powershell.exe directly here, it has to be called from cmd.exe.
 cat << EOF | hivexregedit --merge --prefix 'HKEY_LOCAL_MACHINE\SYSTEM' "${hive_dir}"
 [${control_set}\Services\MigrationManagerFirstBoot]