Add --set-uefi-var

Not working yet

Signed-off-by: Daniel Schaefer <dhs@frame.work>

Author: JohnAZoidberg

framework_lib/src/commandline/clap_std.rs

@@ -254,6 +254,10 @@ struct ClapCli {
     #[arg(long)]
     s0ix_counter: bool,
 
+    /// Set UEFI variable (name, file path)
+    #[arg(long)]
+    set_uefi_var: Option<std::path::PathBuf>,
+
     /// Hash a file of arbitrary data
     #[arg(long)]
     hash: Option<std::path::PathBuf>,
@@ -528,6 +532,7 @@ pub fn parse(args: &[String]) -> Cli {
         ec_hib_delay: args.ec_hib_delay,
         uptimeinfo: args.uptimeinfo,
         s0ix_counter: args.s0ix_counter,
+        set_uefi_var: args.set_uefi_var,
         hash: args.hash.map(|x| x.into_os_string().into_string().unwrap()),
         driver: args.driver,
         pd_addrs,

framework_lib/src/commandline/mod.rs

@@ -216,6 +216,7 @@ pub struct Cli {
     pub ec_hib_delay: Option<Option<u32>>,
     pub uptimeinfo: bool,
     pub s0ix_counter: bool,
+    pub set_uefi_var: Option<std::path::PathBuf>,
     pub hash: Option<String>,
     pub pd_addrs: Option<(u16, u16, u16)>,
     pub pd_ports: Option<(u8, u8, u8)>,
@@ -1510,6 +1511,24 @@ pub fn run_with_args(args: &Cli, _allupdate: bool) -> i32 {
         } else {
             println!("s0ix_counter: Unknown");
         }
+    } else if let Some(filepath) = &args.set_uefi_var {
+        #[cfg(feature = "uefi")]
+        let data = crate::uefi::fs::shell_read_file(filepath);
+        #[cfg(not(feature = "uefi"))]
+        let data = match fs::read(filepath) {
+            Ok(data) => Some(data),
+            // TODO: Perhaps a more user-friendly error
+            Err(e) => {
+                println!("Error {:?}", e);
+                None
+            }
+        };
+        if let Some(data) = data {
+            println!("File");
+            println!("  Size:       {:>20} B", data.len());
+            println!("  Size:       {:>20} KB", data.len() / 1024);
+            os_specific::set_dbx(&data);
+        }
     } else if args.test {
         println!("Self-Test");
         let result = selftest(&ec);

framework_lib/src/os_specific.rs

@@ -55,14 +55,26 @@ pub fn sleep(micros: u64) {
     }
 }
 
-#[cfg(windows)]
-pub fn set_dbx() -> Option<()> {
-    set_uefi_var("dbx", "d719b2cb-3d3a-4596-a3bc-dad00e67656f", &[], 0)
+pub const EFI_VARIABLE_NON_VOLATILE: u32 = 0x00000001;
+pub const EFI_VARIABLE_BOOTSERVICE_ACCESS: u32 = 0x00000002;
+pub const EFI_VARIABLE_RUNTIME_ACCESS: u32 = 0x00000004;
+//pub const EFI_VARIABLE_HARDWARE_ERROR_RECORD: u32 = 0x00000008;
+pub const EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS: u32 = 0x00000010;
+//pub const EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS: u32 = 0x00000020;
+pub const EFI_VARIABLE_APPEND_WRITE: u32 = 0x00000040;
+
+pub fn set_dbx(data: &[u8]) -> Option<()> {
+    let attrs = EFI_VARIABLE_NON_VOLATILE
+        | EFI_VARIABLE_BOOTSERVICE_ACCESS
+        | EFI_VARIABLE_RUNTIME_ACCESS
+        | EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS
+        | EFI_VARIABLE_APPEND_WRITE;
+    set_uefi_var("dbx", "d719b2cb-3d3a-4596-a3bc-dad00e67656f", data, attrs)
 }
 
 #[cfg(windows)]
 pub fn set_uefi_var(name: &str, guid: &str, value: &[u8], attributes: u32) -> Option<()> {
-    unsafe {
+    let res = unsafe {
         SetFirmwareEnvironmentVariableExW(
             // PCWSTR
             &HSTRING::from(name),
@@ -72,6 +84,13 @@ pub fn set_uefi_var(name: &str, guid: &str, value: &[u8], attributes: u32) -> Op
             value.len() as u32,
             attributes,
         )
-        .ok()
-    }
+    };
+    println!("{:?}", res);
+    res.ok()
+}
+
+#[cfg(not(windows))]
+pub fn set_uefi_var(name: &str, guid: &str, value: &[u8], attributes: u32) -> Option<()> {
+    error!("Setting UEFI variable not supported on this OS");
+    None
 }