Parse channel.type using more clear "names"

[SuperSajuuk]

Type of Feature Request

Code

Describe the feature you would like to see implemented.

Currently, if you want to check the channels' type, you have to write code like this:

async def on_message(message):
    if message.channel.type == 1:
        # do something where the channel type equals 1

Writing numbers will get very confusing as you'll have to keep checking the enums.py to see what the numbers mean. To begin with, that will be fine, but if more types are added, it'll not be easy.

In that vein, I'd recommend that we should map channel types more naturally so that you can use the isinstance() method, like so:

async def on_message(message):
    if isinstance(message.channel, fluxer.TextChannel):
        # do something where the channel type is a TextChannel

Obviously, if Fluxer adds new channel types in the future, they can be parsed as ints normally in older library versions until an update of the library adds the proper check.

Why do you think this feature would be beneficial?

It will make code easier to read and avoid situations where people have to keep referencing the enums.py file to see what numbers mean what channel type. Ultimately, people can still do manual integer checks, but its just a lot easier to read the suggested format over numbers.

No Duplicates

• I believe this is not a duplicate request.

Attachments

No response

[Fer2G]

For better readability you can use the ChannelType enum directly

class ChannelType(enum.IntEnum):
    GUILD_TEXT = 0
    DM = 1
    GUILD_VOICE = 2
    GROUP_DM = 3
    GUILD_CATEGORY = 4
    GUILD_ANNOUNCEMENT = 5

Like so

async def on_message(message):
    if message.channel.type == fluxer.enums.ChannelType.DM:
        # do something where the channel is a DM (int = 1)

(or just ChannelType.DM with proper importing)

While I do agree that instance checking could be better, that would require implementation of multiple classes, which may be a bit overkill for the library at the moment, or at least make it harder to implement other things, hopefully we reach that soon though :)

[SuperSajuuk]

For better readability you can use the ChannelType enum directly

class ChannelType(enum.IntEnum):
GUILD_TEXT = 0
DM = 1
GUILD_VOICE = 2
GROUP_DM = 3
GUILD_CATEGORY = 4
GUILD_ANNOUNCEMENT = 5
Like so

async def on_message(message):
if message.channel.type == fluxer.enums.ChannelType.DM:
# do something where the channel is a DM (int = 1)
(or just ChannelType.DM with proper importing)

While I do agree that instance checking could be better, that would require implementation of multiple classes, which may be a bit overkill for the library at the moment, or at least make it harder to implement other things, hopefully we reach that soon though :)

Ah nice, yeah this would probably be better for now! Agree it would be overkill to do the suggested idea, but this would work as an interim (since closeness to discord.py design is important, this may be good to note as a "difference" for when someone is converting a bot from dpy to fluxer.py until that time arrives)