From 650ba074bf1ab24505af346d9b204c9bcb72ddc6 Mon Sep 17 00:00:00 2001 From: Zach Vorhies Date: Mon, 2 Nov 2026 17:31:37 -0800 Subject: [PATCH] test(cli): report the runner error in the issue 208 pipe-writer test The test has failed intermittently on hosted macOS runners (x86 run 41540831671, ARM run 41554072594) at a bare assert!(result.is_ok()), which hides the message. It passes 12/12 locally on Linux under load. Print the runner's error so the next macOS failure names its cause. --- crates/fastled-cli/src/test_mode.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/crates/fastled-cli/src/test_mode.rs b/crates/fastled-cli/src/test_mode.rs index 1cf4a1e0..dbe511f8 100644 --- a/crates/fastled-cli/src/test_mode.rs +++ b/crates/fastled-cli/src/test_mode.rs @@ -807,7 +807,11 @@ mod tests { .await .expect("command runner task did not complete before the test deadline") .unwrap(); - assert!(result.is_ok()); + // Report the runner's message: this has failed intermittently + // on hosted macOS runners and a bare is_ok() hid the cause. + if let Err(error) = result { + panic!("command runner returned an error: {error}"); + } async_engine::sleep(Duration::from_millis(300)).await; assert!(!temp.path().join("late.txt").exists()); });