Fixing Tahoe resize bug

Author: Xpitfire

singularity/AppDelegate.swift

@@ -165,10 +165,15 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
         NotificationCenter.default.addObserver(forName: NSWindow.didChangeOcclusionStateNotification, object: nil, queue: .main) { [weak self] _ in Task { @MainActor in self?.enforceWindowSharingHidden() } }
         NotificationCenter.default.addObserver(forName: NSApplication.didUpdateNotification, object: nil, queue: .main) { [weak self] _ in Task { @MainActor in self?.enforceWindowSharingHidden() } }
         NotificationCenter.default.addObserver(forName: NSWindow.didResignKeyNotification, object: nil, queue: .main) { [weak self] _ in Task { @MainActor in self?.applyWindowAppearance() } }
-        NotificationCenter.default.addObserver(forName: NSWindow.didResizeNotification, object: nil, queue: .main) { [weak self] _ in
-            Task { @MainActor in
-                self?.updateWindowMasks()
-                self?.maybeCloseManualInputOnResize()
+        NotificationCenter.default.addObserver(forName: NSWindow.didResizeNotification, object: nil, queue: .main) { [weak self] n in
+            guard let self = self else { return }
+            // Throttle mask updates during live resize to prevent layout thrashing
+            // Only update if the window being resized is one we care about
+            if let w = n.object as? NSWindow, w.level == .floating || w === self.mainPanelWindow {
+                 Task { @MainActor in
+                     self.updateWindowMasks()
+                     self.maybeCloseManualInputOnResize()
+                 }
             }
         }
         NotificationCenter.default.addObserver(forName: NSWindow.didChangeBackingPropertiesNotification, object: nil, queue: .main) { [weak self] _ in Task { @MainActor in self?.applyWindowAppearance(); self?.updateWindowMasks() } }
@@ -637,8 +642,10 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
         for view in candidates {
             collapseTitlebarView(view)
         }
+        // CRITICAL FIX: Do NOT force layout here. This is called during resize and can cause
+        // recursion or conflicts with AppKit's internal constraint solver (EXC_BAD_INSTRUCTION).
+        // Just mark as needing layout and let the runloop handle it.
         container.needsLayout = true
-        container.layoutSubtreeIfNeeded()
     }
 
     private func collapseTitlebarView(_ view: NSView) {
@@ -653,15 +660,28 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
             frame.size.height = 0
             view.frame = frame
         }
-        if objc_getAssociatedObject(view, &titlebarConstraintKey) as? NSLayoutConstraint == nil {
-            view.translatesAutoresizingMaskIntoConstraints = false
-            let constraint = view.heightAnchor.constraint(equalToConstant: 0)
-            constraint.priority = NSLayoutConstraint.Priority(999)
-            constraint.isActive = true
-            objc_setAssociatedObject(view, &titlebarConstraintKey, constraint, .OBJC_ASSOCIATION_RETAIN_NONATOMIC)
-        } else if let constraint = objc_getAssociatedObject(view, &titlebarConstraintKey) as? NSLayoutConstraint {
-            constraint.constant = 0
-            constraint.isActive = true
+        
+        // Harden constraint logic: only touch constraints if strictly necessary
+        if let constraint = objc_getAssociatedObject(view, &titlebarConstraintKey) as? NSLayoutConstraint {
+            if constraint.constant != 0 {
+                constraint.constant = 0
+            }
+            if !constraint.isActive {
+                constraint.isActive = true
+            }
+        } else {
+            // Check if we already have a zero-height constraint to avoid duplicates
+            let existing = view.constraints.first { $0.firstAttribute == .height && $0.constant == 0 }
+            if let existing = existing {
+                if !existing.isActive { existing.isActive = true }
+                objc_setAssociatedObject(view, &titlebarConstraintKey, existing, .OBJC_ASSOCIATION_RETAIN_NONATOMIC)
+            } else {
+                view.translatesAutoresizingMaskIntoConstraints = false
+                let constraint = view.heightAnchor.constraint(equalToConstant: 0)
+                constraint.priority = NSLayoutConstraint.Priority(999)
+                constraint.isActive = true
+                objc_setAssociatedObject(view, &titlebarConstraintKey, constraint, .OBJC_ASSOCIATION_RETAIN_NONATOMIC)
+            }
         }
         view.subviews.forEach { collapseTitlebarView($0) }
     }

singularity/StartupUpdateCoordinator.swift

@@ -431,7 +431,22 @@ extension StartupUpdateCoordinator {
                 return .skipped(.manifestUnavailable)
             }
             let decoder = JSONDecoder()
-            decoder.dateDecodingStrategy = .iso8601
+            let formatter = ISO8601DateFormatter()
+            formatter.formatOptions = [.withInternetDateTime, .withFractionalSeconds]
+            decoder.dateDecodingStrategy = .custom { decoder in
+                let container = try decoder.singleValueContainer()
+                let string = try container.decode(String.self)
+                if let date = formatter.date(from: string) {
+                    return date
+                }
+                // Fallback for no fractional seconds
+                let formatter2 = ISO8601DateFormatter()
+                formatter2.formatOptions = [.withInternetDateTime]
+                if let date = formatter2.date(from: string) {
+                    return date
+                }
+                throw DecodingError.dataCorruptedError(in: container, debugDescription: "Expected date string to be ISO8601-formatted.")
+            }
             let manifest = try decoder.decode(UpdateManifest.self, from: data)
             return .manifest(manifest)
         } catch {